Skip to content

Confusing ignored files prompt #577

@adam-lynch

Description

@adam-lynch

Description

I got the following prompt when running np today:

The following new files are not already part of your published package:
- .../config/dependenciesObjectContainsToDesktopCLI/index.js
- .../dependenciesObjectMissingToDesktopRuntime/index.js
Continue? y/N

These files will not be published. They're both inside test/fixtures and this is the files property in my package.json;

	"files": [
		"build",
		"docs",
		".env",
		"LICENSE",
		"README.md"
	]

Steps to reproduce

  1. Set up a project with a similar files property.
  2. Publish.
  3. Add some files inside an npm-ignored directory.
  4. Try to publish again.

I'm not 100% sure about this because I haven't seen this prompt before. Maybe something changed in np since the last time I published (I use npx)

Expected behavior

I shouldn't be seeing this prompt. Also, I found the message unclear. To me it's not clear this is related to ignored files, I discovered that by looking at the source.

Environment

np - 7.0.0 (I use npx)
Node.js - 10.18.0
npm - 6.13.4
Git - 2.24.3 (Apple Git-128)
OS - macOS Catalina 10.15.2

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions