BREAKING CHANGE: remove assert.failException property #2659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2659 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 39 39
Lines 1891 1891
=======================================
Hits 1812 1812
Misses 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was used for allowing customisation of the thrown error between sandboxes and for customisation for integrations (most likely from the days of BusterJS). To my knowledge and what I've been able to find on GitHub, this has never had any _production_ use by end users. BREAKING CHANGE: this removes assert.failException from the API
mroderick
force-pushed
the
remove-fail-exception
branch
from
87c7207 to
b09dc5d
Compare
fatso83
approved these changes
Jun 9, 2025
|
This has been publish to the npm registry as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2658
Purpose
Remove
sinon.assert.failException, which makessinonslightly smaller and makes tests run slightly faster.Background
This was used for allowing customisation of the thrown error between sandboxes and for customisation for integrations (most likely from the days of BusterJS).
To my knowledge and what I've been able to find on GitHub, this has never had any production use by end users.
How to verify - mandatory
npm installnpm testChecklist for author
npm run lintpasses