BREAKING CHANGE: remove assert.failException property

[mroderick]

Fixes #2658

Purpose

Remove sinon.assert.failException, which makes sinon slightly smaller and makes tests run slightly faster.

Background

This was used for allowing customisation of the thrown error between sandboxes and for customisation for integrations (most likely from the days of BusterJS).

To my knowledge and what I've been able to find on GitHub, this has never had any production use by end users.

How to verify - mandatory

1. Check out this branch
2. npm install
3. npm test

Checklist for author

• npm run lint passes
• References to standard library functions are cached.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (c720235) to head (b09dc5d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2659   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          39       39           
  Lines        1891     1891           
=======================================
  Hits         1812     1812           
  Misses         79       79           

Flag	Coverage Δ
unit	95.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mroderick]

This has been publish to the npm registry as sinon@21.0.0.

[SchroederSteffen]

Missed to remove failException from the documentation. Opened #2666 for that.