[BUG] mcp not working in agent mode

[Iiiiiiigor]

Quick Summary

"picoclaw agent" ignores mcp tools completely

Environment & Tools

• PicoClaw Version: v0.2.1-12-gb89f644
• Go Version: go1.25.7
• AI Model & Provider: llama.cpp
• Operating System: Linux
• Channels: Telegram

📸 Steps to Reproduce

1. Configure mcp tools (anything)
2. start picoclaw agent -d
3. observe the lack of mcp anything

❌ Actual Behavior

mcp tools are defunct in agent mode, but work in gateway mode.

✅ Expected Behavior

picoclaw agent and picoclaw gateway both use mcp tools in the same way

💬 Additional Context

[nikolasdehor]

The root cause is clear from the code. MCP tools are only loaded inside AgentLoop.Run() in pkg/agent/loop.go (line 245-313):

func (al *AgentLoop) Run(ctx context.Context) error {
    // ...
    mcpManager := mcp.NewManager()
    // ... loads servers, registers tools for all agents ...
}

But picoclaw agent mode (in cmd/picoclaw/internal/agent/helpers.go) never calls Run() — it uses ProcessDirect() / ProcessDirectWithChannel() instead (line 66):

agentLoop := agent.NewAgentLoop(cfg, msgBus, provider)
response, err := agentLoop.ProcessDirect(ctx, input, sessionKey)

ProcessDirect (defined at pkg/agent/loop.go line 567) goes directly to message processing without the MCP initialization that happens in Run().

Fix: Extract the MCP loading logic from Run() into a separate method like InitMCPTools(ctx), and call it from both Run() and NewAgentLoop() (or lazily on first ProcessDirect call). The cleanup (mcpManager.Close()) would need to move to the AgentLoop.Close() method.

This should be a relatively contained fix — the MCP loading block (lines 245-350) is self-contained and doesn't depend on the message bus subscription that Run() sets up.