Skip to content

feat(chat): add chat detail visibility selector#2886

Merged
lxowalle merged 1 commit into
sipeed:mainfrom
lc6464:feat/chat-detail-visibility-select
May 18, 2026
Merged

feat(chat): add chat detail visibility selector#2886
lxowalle merged 1 commit into
sipeed:mainfrom
lc6464:feat/chat-detail-visibility-select

Conversation

@lc6464
Copy link
Copy Markdown
Contributor

@lc6464 lc6464 commented May 17, 2026

📝 Description

Replace the Web Chat assistant detail toggle with a four-state selector for reasoning and tool call visibility.

This PR updates the chat header control to support showing neither, reasoning only, tool calls only, or both. It also migrates the stored browser preference from the legacy boolean key to a new enum-based key and keeps the migration resilient when storage access is restricted.

🗣️ Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 📖 Documentation update
  • ⚡ Code refactoring (no functional changes, no api changes)

🤖 AI Code Generation

  • 🤖 Fully AI-generated (100% AI, 0% Human)
  • 🛠️ Mostly AI-generated (AI draft, Human verified/modified)
  • 👨‍💻 Mostly Human-written (Human lead, AI assisted or none)

📚 Technical Context

  • Reference URL: N/A
  • Reasoning: Replace the binary assistant detail toggle with a selector that matches the four supported visibility modes, preserve existing user preference data through localStorage migration, and fall back safely to all when browser storage is unavailable or write-restricted.

🧪 Test Environment

  • Hardware: Local x64 Server
  • OS: Ubuntu Server 24
  • Model/Provider: -
  • Channels: Web

📸 Evidence

Click to view Logs/Screenshots

Select, Chinese:
image

Tool calls only, English:
image

☑️ Checklist

  • My code/docs follow the style of this project.
  • I have performed a self-review of my own changes.
  • I have updated the documentation accordingly.

@lc6464 lc6464 marked this pull request as ready for review May 17, 2026 10:04
@lc6464 lc6464 changed the title feat(web): add chat detail visibility selector feat(chat): add chat detail visibility selector May 17, 2026
Copy link
Copy Markdown
Collaborator

@lxowalle lxowalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the code conflict

@lc6464 lc6464 force-pushed the feat/chat-detail-visibility-select branch from 332e76a to 3e62d8c Compare May 18, 2026 02:32
@lc6464 lc6464 requested a review from lxowalle May 18, 2026 02:36
@lc6464
Copy link
Copy Markdown
Contributor Author

lc6464 commented May 18, 2026

Please resolve the code conflict

@lxowalle Conflicts have been resolved.

Please review again, thanks!

Copy link
Copy Markdown
Collaborator

@lxowalle lxowalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lxowalle lxowalle merged commit 941bac2 into sipeed:main May 18, 2026
5 checks passed
@lc6464 lc6464 deleted the feat/chat-detail-visibility-select branch May 18, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants