Better handling of hidden builtins #278
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a generalized algorithm to handle builtins exposed via the `types` module, but reporting `builtins` at introspection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a generalized algorithm to handle builtins exposed via the
typesmodule, but reportingbuiltinsat introspection.Why
Importing types, via pybind11 such as py::module::import("types").attr("MappingProxyType") currently yields an unresolved name "mappingproxy" in the generated .pyi stubs.
The reason for this is that the
MappingProxyType.__qualname__at runtime is "mappingproxy" and__module__is "builtins". However, the actual builtins module does not expose this as an importable attribute.There are a number of other "hidden" builtins that follow this pattern. They all seem to come from the types module. I also left room for overriding this behavior, as was done before for "function" and "builtin_function_or_method".