-
Notifications
You must be signed in to change notification settings - Fork 0
Fixes for tests #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed keys in `intrinsicTypeKinds` not matching type names in es5.lib.d.ts Fixed `getIntrinsicMappingType` behaving incorrectly Fixed incorrect baseline reference for `recursiveConditionalTypes` Fixed incorrect baseline reference for `intrinsicTypes`
Thanks so much for this awesome PR! I'm impressed by the work you've done and hope it will merge well with upstream too again ✅ 🚀 Are you still working on it or do you want it merged already? |
Thank you for the PR! I'll be honest, I don't have a lot of hope that the Typescript team will merge this feature; I did it more as a proof-of-concept. I figure even if they did want to add this functionality, they'd probably implement it in their own way. Still, nice to have a working example. |
It was ready to be merged
There is clearly demand for it. We've done the hard work, it shouldn't be too difficult for them to review and merge. Hopefully they can take a look at it soon! |
There is clearly demand and the fact we come together to keep it updated represents that - but yea, I see both sides 😅 @skeate Just for completeness, maybe you could update the first PR post from |
Hi there @skeate, I fixed a few things and now tests pass:
intrinsicTypeKinds
not matching the types ines5.lib.d.ts
(intrinsicTypeKinds
usedSub
,Mul
, andDiv
for keys, but lib.d.ts usedSubtract
,Multiply
, andDivide
)getIntrinsicMappingType
not working correctly onInteger<any>
,Integer<number>
,Integer<bigint>
Integer
toFloor
, since that is much less ambiguousCeil
andRound
typesCalculation
conditional ingetIntrinsicMappingType
getIntrinsicMappingType
/2
andapplyNumberMapping
/2
recursiveConditionalCrash4
(Renamed a type fromAdd
toAddTuple
)Please take a look at this, I look forward to getting it merged into Typescript!