Skip to content

[MNT] Add missing distr:paramtype tag to Skellam, GumbelL, GumbelR, FDist, Rayleigh #942

@ANANYA542

Description

@ANANYA542

Describe the maintenance issue

Several distributions are missing the "distr:paramtype": "parametric" tag in their _tags dictionary. Methods like get_params_df() and to_df() rely on get_class_tag("distr:paramtype") == "parametric" to handle distributions correctly. Without this tag, these distributions are silently incompatible with parts of the framework API.
The following files are affected:

skpro/distributions/skellam.py
skpro/distributions/gumbel_l.py
skpro/distributions/gumbel_r.py
skpro/distributions/f_dist.py
skpro/distributions/rayleigh.py

All five are parametric distributions and should declare this tag, consistent with Normal, Cauchy, Exponential, and others that already do.

To Reproduce
pythonfrom skpro.distributions import Skellam, Normal
print(Normal.get_class_tag("distr:paramtype"))
(Returns: 'parametric')
print(Skellam.get_class_tag("distr:paramtype"))
(Raises ValueError: Tag with name distr:paramtype could not be found)

A screenshot of the reproduction output is attached below.
Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    maintenanceContinuous integration, unit testing & package distribution

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions