Unblocks Grammarly #3005
Merged
Unblocks Grammarly #3005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
Thanks for the PR. For posterity the issue before was Grammerly would modify the DOM contents Quill wants to manage to show its highlights/underlines. Now there is an overlay so there is no conflict. |
Contributor
Author
|
@jhchen Thank you 👍 |
volser
added a commit
to volser/quill
that referenced
this pull request
Jul 2, 2020
This reverts commit 929dde1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
Since Grammarly now works well on Quill in all browsers, we no longer need to block it.
This PR unblocks Grammarly from integrating on Quill.