Skip to content

Rename isBmpLast, used for Unicode data #176

Description

@slevithan

In the Unicode data generators (under tools/) and Unicode addons, rename isBmpLast as the more descriptive hasOrphanHighSurrogatesAndAstral. It's only used for category C and property Any, so the long name doesn't matter.

  • Or just hasOrphanHighSurrogates and let Unicode Base know to also check whether there is astral data before flipping the order of bmp and astral data.
  • Or just hasOrphanSurrogates and let Unicode Base know to also check whether there is astral data before flipping the order. This would mean attaching this prop in more cases where it isn’t currently useful (either because there’s no astral data or there are only low surrogates), but that’s probably not so bad.

Activity

slevithan commented on Feb 17, 2018

@slevithan
OwnerAuthor

I don't think this should be treated as a breaking change, since isBmpLast is unlikely to be used by any existing addons outside of the official XRegExp Unicode addons (which themselves barely use it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions