compiler: Fix the API for disabling the default translation context #10267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
force-pushed
the
olivier/translations
branch
from
032bb59 to
e5e1580
Compare
ogoffart
commented
Dec 11, 2025
Comment on lines
+178
to
+179
| compiler_config.default_translation_context = | ||
| i_slint_compiler::DefaultTranslationContext::None; |
Member
Author
There was a problem hiding this comment.
I realized the implementation in the slint-compiler was missing, so this fixes it.
ogoffart
force-pushed
the
olivier/translations
branch
from
e5e1580 to
a49c7ff
Compare
Use an enum instead of a boolean flag
ogoffart
force-pushed
the
olivier/translations
branch
from
a49c7ff to
3885f11
Compare
tronical
approved these changes
Dec 12, 2025
Co-authored-by: Simon Hausmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an enum instead of a boolean flag
The cmake and slint-tr-extractor API remain unchanged.