-
Notifications
You must be signed in to change notification settings - Fork 45
add some basic testing for useAsync #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c763f73
set up testing with tsconfig.test.json
dagda1 2dd6d27
test for successful request
dagda1 c5b5263
add error tests
dagda1 b669d6f
add assertions on onSuccess and onError
dagda1 e781885
remove jest-fetch-mock and initialProps from tests
dagda1 726e0cf
remove explicit typing and Promis.resolve
dagda1 12a4292
remove Promise.reject
dagda1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
import { useAsync } from '../src'; | ||
import { renderHook } from '@testing-library/react-hooks'; | ||
|
||
interface StarwarsHero { | ||
name: string; | ||
} | ||
|
||
export const generateMockResponseData = (amount: number = 5): StarwarsHero[] => | ||
[...Array(amount).keys()].map(n => ({ | ||
id: n + 1, | ||
name: `Starwars Hero ${n + 1}`, | ||
})); | ||
|
||
describe('useAync', () => { | ||
const fakeResults = generateMockResponseData(); | ||
|
||
it('should have a useAsync hook', () => { | ||
expect(useAsync).toBeDefined(); | ||
}); | ||
|
||
it('should resolve a successful request', async () => { | ||
const onSuccess = jest.fn(); | ||
const onError = jest.fn(); | ||
|
||
const { result, waitForNextUpdate } = renderHook(() => | ||
useAsync( | ||
async () => { | ||
return Promise.resolve(fakeResults); | ||
}, | ||
[], | ||
{ | ||
onSuccess: () => onSuccess(), | ||
onError: () => onError(), | ||
} | ||
) | ||
); | ||
|
||
expect(result.current.loading).toBe(true); | ||
|
||
await waitForNextUpdate(); | ||
|
||
expect(result.current.result).toEqual(fakeResults); | ||
expect(result.current.loading).toBe(false); | ||
expect(result.current.error).toBeUndefined(); | ||
expect(onSuccess).toHaveBeenCalled(); | ||
expect(onError).not.toHaveBeenCalled(); | ||
}); | ||
|
||
it('should set error detail for unsuccessful request', async () => { | ||
const onSuccess = jest.fn(); | ||
const onError = jest.fn(); | ||
|
||
const { result, waitForNextUpdate } = renderHook(() => | ||
useAsync( | ||
async () => { | ||
throw new Error('something went wrong'); | ||
}, | ||
[], | ||
{ | ||
onSuccess: () => onSuccess(), | ||
onError: () => onError(), | ||
} | ||
) | ||
); | ||
|
||
await waitForNextUpdate(); | ||
|
||
expect(result.current.error).toBeDefined(); | ||
expect(result.current.error!.message).toBe('something went wrong'); | ||
expect(result.current.loading).toBe(false); | ||
expect(result.current.result).toBeUndefined(); | ||
expect(onSuccess).not.toHaveBeenCalled(); | ||
expect(onError).toHaveBeenCalled(); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
{ | ||
"include": ["src", "types"], | ||
"exclude": ["test"], | ||
"compilerOptions": { | ||
"target": "es5", | ||
"module": "esnext", | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"extends": "./tsconfig.json", | ||
"compilerOptions": { | ||
"downlevelIteration": true | ||
}, | ||
"include": ["src/**/*.ts", "test/**/*.ts"] | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.