E2E: go workflow_dispatch branch1 SLSA3 config-ldflags

[laurentsimon]

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/2388373383
Workflow name: go workflow_dispatch branch1 SLSA3 config-ldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Thu May 26 03:03:54 UTC 2022

[laurentsimon]

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/2394314902
Workflow name: go workflow_dispatch branch1 SLSA3 config-ldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Fri May 27 03:04:59 UTC 2022

[laurentsimon]

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/2399698331
Workflow name: go workflow_dispatch branch1 SLSA3 config-ldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Sat May 28 02:47:13 UTC 2022

[laurentsimon]

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/2402991800
Workflow name: go workflow_dispatch branch1 SLSA3 config-ldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Sun May 29 03:07:40 UTC 2022

[laurentsimon]

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/2406517657
Workflow name: go workflow_dispatch branch1 SLSA3 config-ldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Mon May 30 03:09:33 UTC 2022

[ianlewis]

This seems to be caused by

slsa-github-generator/.github/workflows/scripts/builder-fetch.sh

Lines 14 to 20 in dc15f82

	PREFIX="refs/tags/"
	# Extract version.
	if [[ "$BUILDER_REF" =~ "^$PREFIX*" ]]; then
	echo "Invalid ref: $BUILDER_REF"
	exit 2
	fi

builder-fetch.sh expects the builder ref to start with refs/tags but we reference it via refs/heads/main in e2e tests.

However, the builder shouldn't be fetched at all because the workflow is called with the compile-builder flag. For some reason this flag isn't being used properly.
https://github.com/slsa-framework/example-package/blob/c30254b4a76d1ecd73871eb8dad0f834757f5a1f/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml#L80

[ianlewis]

The problem seems to be that branch1 is behind main and so it's using an old version of the e2e test workflow which doesn't send compile-builder

@laurentsimon Is branch1 supposed to stay up to date with main?

[ianlewis]

It seems branch1 just wasn't updated based on https://github.com/slsa-framework/example-package/blob/branch1/.github/workflows/README.md so I updated it to the latest main. The next e2e test run should succeed I think.

[laurentsimon]

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/2412385043
Workflow name: go workflow_dispatch branch1 SLSA3 config-ldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Tue May 31 03:06:50 UTC 2022

Tests are passing now. Closing this issue.