Change format of subjects to base64#174
Merged
Merged
Conversation
ianlewis
requested review from
MarkLodato,
asraa,
joshuagl and
laurentsimon
as code owners
asraa
reviewed
Jun 6, 2022
asraa
left a comment
asraa
left a comment
Contributor
There was a problem hiding this comment.
Nice cleanup! I would also wonder, could you enhance the example in README.md to have 2 subjects? I wonder if it it's unclear how to format two subjects with the base64 encoding
laurentsimon
reviewed
Jun 6, 2022
laurentsimon
approved these changes
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #165