Skip to content

Fix Makefile for darwin/arm64 -targets #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aleksipirttimaa
Copy link
Contributor

@aleksipirttimaa aleksipirttimaa commented Jul 18, 2025

Closes #1461

Makefile contained an apparent typo.

Tested on

  • go version go1.24.5 darwin/arm64
  • GNU Make 3.81
  • macOS 15.5

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jul 18, 2025
@aleksipirttimaa aleksipirttimaa changed the title Fix Makefile for darwin/amd64 -targets Fix Makefile for darwin/arm64 -targets Jul 18, 2025
@hslatman hslatman added this to the v0.28.8 milestone Jul 28, 2025
@hslatman hslatman merged commit 1308bd9 into smallstep:master Jul 28, 2025
15 of 16 checks passed
@hslatman
Copy link
Member

hslatman commented Jul 28, 2025

Thank you, @aleksipirttimaa 🙂

It might be better to rewrite the Makefile to make use of GoReleaser, as we're generally not using those make invocations (at least not in CI), further consolidating our build process, but that's for another day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: make -w binary-darwin-arm64 results in an amd64 -binary
2 participants