Work in progress: harmonize test ids across fixture unionsa and parametrize with fixture refs #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 3, 2020 16:45
- added an `alternative_index` attribute in `UnionFixtureAlternative` and uniformized the id making process for fixture unions and parametrize alternatives. - in particular added an `id` argument to `fixture_ref` and filled this `id` in `@parametrize_with_cases` so that the id is always the one from the case_id
added 5 commits
December 9, 2020 09:27
…_case_info`, `set_case_id`, `get_case_id`, `get_case_marks`, `get_case_tags`, `matches_tag_query`, `is_case_class`, `is_case_function`.
…s inside unions either from `fixture_union` or in `@parametrize` with `fixture_ref` (or `@parametrize_with_cases`) Passing a callable to `idstyle` and `ids` in `@parametrize` and `@parametrize_with_cases` is fully supported, as well as most manners of passing marks, including in pytest 2. `get_marked_parameter_values` now works correctly in pytest 2. `mini_idvalset` now handles lazy_values. Useless arguments such as `ids` in `_fixture_product` and `idgen` in `@parametrize_with_case` removed. Generated fixture names through `check_name_available` are now checked and modified so that they are correct identifiers, with a new util method named `make_identifier` Case functions transformed into a fixture and containing both a parametrization mark and other marks are now correctly supported. New constant `PYTEST3_OR_GREATER` used everywhere for pytest 2 compat. `resolve_ids` enhanced `transform_marks_into_decorators` renamed `markinfos_to_markdecorators`. New functions `markdecorators_as_tuple` and `markdecorators_to_markinfos`
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 91.22% 90.97% -0.25%
==========================================
Files 130 132 +2
Lines 5025 5376 +351
==========================================
+ Hits 4584 4891 +307
- Misses 441 485 +44
Continue to review full report at Codecov.
|
added 8 commits
December 14, 2020 22:58
…est between 3 and 4.2.1
Fixed `get_callspec`: marks had to be added even in python 3 < 3.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154