schema: expand Period schemas, if either of the fields are present #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e. if period.end is there, but not .start - still return .start in our schema - just as a kindness to consumers that likely will always want both. Fixes smart-on-fhir/cumulus#66
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
dogversioning
left a comment
dogversioning
left a comment
There was a problem hiding this comment.
oh thank you this is going to make my life so much easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. if period.end is there, but not .start - still return .start in our schema - just as a kindness to consumers that likely will always want both.
This will also likely be useful for any future attempt by Library to coalesce various complicated dates into one value.
Fixes smart-on-fhir/cumulus#66