Skip to content

Initialize DonTime Plugin, Store, and TimeProvider for Executions #18355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 50 commits into
base: develop
Choose a base branch
from
Open

Initialize DonTime Plugin, Store, and TimeProvider for Executions #18355

wants to merge 50 commits into from

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Jun 26, 2025 •
edited
Loading

This PR integrates the DonTime plugin and sets up its required components to support time in executions:

  • Adds a DonTimeStore to the Application for managing DON and Node Time requests.
  • Implements a custom TimeProvider for Executions that retrieves DON Time and tracks workflow time call sequences.
  • Initializes and wires the DonTime plugin into the delegate.

These changes enable workflow executions to utilize synchronized DON Time for accurate and traceable timing behaviour.

Jira Ticket

Note: Set allow-lint-issues label since linter is complaining about delegate.go err shadowing unrelated to these changes.

@DylanTinianov DylanTinianov self-assigned this Jun 26, 2025
nolag
nolag previously approved these changes Jun 26, 2025
View reviewed changes
@DylanTinianov DylanTinianov changed the title Hook donTimeStore to time module Implement TimeProvider for Executions Jun 26, 2025
@DylanTinianov DylanTinianov marked this pull request as ready for review June 26, 2025 18:52
@DylanTinianov DylanTinianov requested review from a team as code owners June 26, 2025 18:52
@DylanTinianov DylanTinianov requested a review from nolag June 26, 2025 19:04
bolekk
bolekk reviewed Jun 26, 2025
View reviewed changes
nolag
nolag reviewed Jun 27, 2025
View reviewed changes
nolag
nolag previously approved these changes Jun 27, 2025
View reviewed changes
@DylanTinianov DylanTinianov requested a review from a team as a code owner July 4, 2025 21:12
@DylanTinianov DylanTinianov changed the title Initialize DonTime Plugin & TimeProvider for Executions Initialize DonTime Plugin, Store, and TimeProvider for Executions Jul 14, 2025
@DylanTinianov DylanTinianov requested review from bolekk and nolag July 14, 2025 16:26
nolag
nolag previously approved these changes Jul 14, 2025
View reviewed changes
bolekk
bolekk requested changes Jul 15, 2025
View reviewed changes
@DylanTinianov DylanTinianov force-pushed the CAPPL-903-time-module-hook branch from a0c5bea to a9a2cd3 Compare July 16, 2025 13:39
@DylanTinianov DylanTinianov removed the allow-lint-issues Allow merging despite linter issues. Do not abuse. label Jul 17, 2025
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

@DylanTinianov DylanTinianov requested review from bolekk and nolag July 17, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolag nolag nolag approved these changes

@pavel-raykov pavel-raykov Awaiting requested review from pavel-raykov pavel-raykov is a code owner automatically assigned from smartcontractkit/foundations

@bolekk bolekk Awaiting requested review from bolekk

Requested changes must be addressed to merge this pull request.

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DylanTinianov @bolekk @nolag