feat(deployment): Integrate Aptos to curse/uncurse CS #18361
+475
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigombsoares
force-pushed
the
feat-aptos-curse
branch
2 times, most recently
from
ba7c50e to
22066c7
Compare
rodrigombsoares
commented
Jul 17, 2025
Comment on lines
-71
to
-74
| if err != nil { | ||
| return fmt.Errorf("failed to load onchain state: %w", err) | ||
| } | ||
|
|
rodrigombsoares
requested review from
winder,
asoliman92,
matYang,
makramkd,
AmrMohamedRezk,
dimkouv and
b-gopalswami
product-security-plaid-test
bot
requested review from
erikburt,
gustavogama-cll,
ajaskolski,
bytesizedroll,
CL-Eric,
DimitriosNaikopoulos,
giogam,
graham-chainlink,
jkongie and
securejavier
carte7000
previously approved these changes
Jul 17, 2025
rodrigombsoares
force-pushed
the
feat-aptos-curse
branch
from
c958e53 to
9421e69
Compare
|
carte7000
approved these changes
Jul 23, 2025
KodeyThomas
approved these changes
Jul 23, 2025
winder
reviewed
Jul 23, 2025
| cldf_chain "github.com/smartcontractkit/chainlink-deployments-framework/chain" | ||
|
|
||
| aptosCCIP "github.com/smartcontractkit/chainlink-aptos/bindings/ccip" | ||
| aptosOffRamp "github.com/smartcontractkit/chainlink-aptos/bindings/ccip_offramp" |
There was a problem hiding this comment.
Looks like the bindings aren't versioned. Solana does it the same way and it recently became a problem. I'd recommend something like the way it's done for EVM bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Aptos support on curse/uncurse changesets. We don't have DeployerGroup support for Aptos, it uses OperationsAPI.
AptosCursableChainimplementingCursableChainand runs operations to curse/uncurse returning MCMS operations that are then added to the final proposal.Features
AptosCursableChainimplementingCursableChaininterfaceTesting
integration-tests/smoke/ccip/ccip_cs_rmn_curse_uncurse_test.goThere's a separate test for Aptos since initializing an env with Aptos chain for all the current
CurseTestCasewould increase CI time.