Skip to content

Added a Nib based UITableViewCell #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Added a Nib based UITableViewCell #2

wants to merge 5 commits into from

Conversation

mbogh
Copy link

@mbogh mbogh commented Jun 9, 2014

Hi,
I have added a Nib based UITableViewCell which is self-sizing to make the example more complete.
The Nib based cell can be activated by commenting in L:40 and and commenting out L:39.
/cc #1

@smileyborg
Copy link
Owner

Very cool! I'm working on merging this in. In my testing, I found a few tweaks that were needed (for example: cellForRowAtIndexPath: is not expecting the IB cell class). But should have this integrated soon, thanks for putting it together!

@smileyborg smileyborg mentioned this pull request Jun 11, 2014
@mbogh
Copy link
Author

mbogh commented Jun 11, 2014

Thanks :)

I did not make any modifications to cellForRowAtIndexPath:to keep it as simple as possible but I can see it could cause confusion.

Or are you having other issues with the code?

@smileyborg
Copy link
Owner

OK - got it merged in.

There are 2 outstanding issues that I was unable to resolve, they seem like Apple bugs at this point:

  1. Cells loaded from a nib do not size correctly in iOS 8 when the table view width is not 320pts (e.g. landscape iPhone, any iPad). (Programmatically loaded cells work fine.)
  2. Changing the Dynamic Type slider while the app is running does not fire the UIContentSizeCategoryDidChangeNotification, meaning the app does not respond by updating its UI until it is killed and launched again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants