[DRAFT] Pure python request pipeline #429
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
pure-python-request-pipeline
branch
from
bb29685 to
3a6df83
Compare
This decouples auth from HTTP, allowing it to be defined centrally. A number of changes have been made to various interfaces. Notably identity resolvers are generally expected to have zero-arg constructors, instead getting everything they need from their properties where possible. Construction of event signers has been moved into AuthScheme. Right now it takes the entire context of the request during construction, but we should consider passing identity and signing properties in at signing time like normal signers so that they can be reused.
JordonPhillips
force-pushed
the
pure-python-request-pipeline
branch
2 times, most recently
from
ec58e87 to
1890159
Compare
JordonPhillips
force-pushed
the
pure-python-request-pipeline
branch
from
1890159 to
0e83eeb
Compare
nateprewitt
reviewed
Apr 11, 2025
JordonPhillips
force-pushed
the
no-http-auth
branch
from
7ad2adf to
6f474c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of the non-codegen request pipeline. It's at a point where it looks like what it'll look like in the final draft, but there's some other components that need to be updated still, namely:
classifymethod, based on the response.write_event_stream/read_event_stream) but Python doesn't have some standard thing like Flow to fall back on so it's not quite so simple.Requestshould handle that with aretryableandresetmethod.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.