Correctly serialize Strings in XML
#1832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic that keeps track of whether we're working with a borrowed or an owned value is flawed. It just so happened to work when requesting owned values from borrowed values because we called `autoDeref` before creating the value expression. That logic should instead be used _within_ `ValueExpression` to appease Clippy there too. Fixes #1831.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
Oct 10, 2022
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Merged
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic that keeps track of whether we're working with a borrowed or
an owned value is flawed. It just so happened to work when requesting
owned values from borrowed values because we called
autoDerefbeforecreating the value expression. That logic should instead be used
within
ValueExpressionto appease Clippy there too.Fixes #1831.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.