Simplify implementation of rendering prefix headers #1841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation that binds the target of `@httpPrefixHeaders`-annotated member shapes is overly complex in that it accounts for the possibility of it targeting a list shape. However, `@httpPrefixHeaders` can only be applied to structure members targeting map shapes: * https://awslabs.github.io/smithy/1.0/spec/core/http-traits.html#httpprefixheaders-trait * https://awslabs.github.io/smithy/2.0/spec/http-bindings.html#httpprefixheaders-trait The existing implementation likely came to be by copy-pasting the `RustWriter.renderHeaders` extension function. I've also taken the liberty of reformatting and renaming variables for clarity and consistency.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Merged
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
deleted the
davidpz/simplify-implementation-of-rendering-prefix-headers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation that binds the target of
@httpPrefixHeaders-annotated member shapes is overly complex in thatit accounts for the possibility of it targeting a list shape. However,
@httpPrefixHeaderscan only be applied to structure members targetingmap shapes:
The existing implementation likely came to be by copy-pasting the
RustWriter.renderHeadersextension function.I've also taken the liberty of reformatting and renaming variables for
clarity and consistency.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.