Improve RustDocs for constrained types #2095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We decided not to generate `parse` method in #1342. * Fix link to `try_from` constructor. * Always mention the type is the result of a constrained shape, even if the shape has no documentation.
david-perez
requested review from
crisidev and
jdisanti
and removed request for
jdisanti
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
crisidev
approved these changes
Dec 13, 2022
david-perez
deleted the
davidpz/improve-rustdocs-for-constrained-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parsemethod in Builders of builders #1342.try_fromconstructor.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.