POC: Provide Set<ShapeId> to onRemove #2557
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
commented
Mar 10, 2025
| @@ -44,10 +47,12 @@ Model transform(ModelTransformer transformer, Model model) { | |||
| removed.addAll(removedShape.members()); | |||
| } | |||
|
|
|||
| Set<ShapeId> removedIds = removed.stream().map(Shape::getId).collect(Collectors.toSet()); | |||
There was a problem hiding this comment.
thought: This traversal itself has some overhead, we can make it lazy if needed, but I'd wager it's going to be beneficial as more plugins are migrated to use this variable.
The whole thing definitely needs some benchmarks, I can get some profiling going on my own build another time.
kubukoz
commented
Mar 10, 2025
| @@ -27,4 +30,8 @@ public interface ModelTransformerPlugin { | |||
| default Model onRemove(ModelTransformer transformer, Collection<Shape> removed, Model model) { | |||
There was a problem hiding this comment.
thought: left for binary compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#2556 - trying to filter shapes more effectively.
Testing
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.