Refactor minor activities #7766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnikaCodes
added
the
crashes /hotpatch
Zarel
reviewed
Dec 14, 2020
Zarel
reviewed
Dec 14, 2020
Zarel
reviewed
Dec 14, 2020
Zarel
approved these changes
Dec 14, 2020
|
(Haha get it "minor"????) |
|
Reminder to add conversion functions for pre-existing roomsettings. |
yeah, just trying to fix this crash first then i will |
mia-pi-git
requested changes
Dec 31, 2020
Zarel
reviewed
Jan 3, 2021
| if (this.minorActivity && 'voters' in this.minorActivity) { | ||
| if (user.id in this.minorActivity.voters) this.minorActivity.updateFor(user); | ||
| } | ||
| this.minorActivity?.onRename?.(user, oldid, joining); |
There was a problem hiding this comment.
Is this actually necessary? onRename only applies if IP stays the same, and the IP should already be in the "already voted" table.
| @@ -889,8 +928,8 @@ export abstract class BasicRoom { | |||
| this.users[user.id] = user; | |||
| this.userCount++; | |||
|
|
|||
| if (this.minorActivity) this.minorActivity.onConnect(user, connection); | |||
| if (this.game && this.game.onJoin) this.game.onJoin(user, connection); | |||
| this.minorActivity?.onConnect?.(user, connection); | |||
There was a problem hiding this comment.
Is this necessary? This will call onConnect twice when a user joins.
mia-pi-git
approved these changes
Jan 5, 2021
|
I guess I'll figure out the |
Quanyails
pushed a commit
to Quanyails/Pokemon-Showdown
that referenced
this pull request
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.