Skip to content

Add Timer::pause#239

Merged
notgull merged 1 commit intosmol-rs:masterfrom
yshui-forks:master
Aug 7, 2025
Merged

Add Timer::pause#239
notgull merged 1 commit intosmol-rs:masterfrom
yshui-forks:master

Conversation

@yshui
Copy link
Copy Markdown
Contributor

@yshui yshui commented Aug 5, 2025

Closes #238

Copy link
Copy Markdown
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to just make "clear" public.

Closes smol-rs#238

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@yshui
Copy link
Copy Markdown
Contributor Author

yshui commented Aug 6, 2025

@notgull updated. i don't know if setting self.when = None; is necessary, but i did that to be consistent with the other cases of turing-timer-offs.

Copy link
Copy Markdown
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit d1c6738 into smol-rs:master Aug 7, 2025
24 checks passed
@taiki-e taiki-e mentioned this pull request Sep 13, 2025
@taiki-e
Copy link
Copy Markdown
Collaborator

taiki-e commented Sep 14, 2025

Published in 2.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

stop timer

3 participants