Add an efficient implementation based on critical-section #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current no-std implementation is somewhat ineffecient, potentially broken and relies on some slow data structures. The main reason why we use this implementation is because we don't have a way to "lock" the linked list, since there's no way to lock things in no-std. However, many embedded platforms have a concept of a "critical section" that can be used to exclusively lock something. This PR adds an option to the "std" implementation that replaces the existing Mutex with a usage of the critical-section crate. This is enabled with the "critical-section" feature. This allows us to have the advantages of the std-based implementation without needing to rely on std for platforms that don't have it. Signed-off-by: John Nunley <[email protected]>
zeenix
reviewed
Nov 17, 2024
Since `std.rs` and `no_std.rs` no longer correspond to std and no_std, I've renamed them based on the underlying algorithm used. `std.rs` is now `intrusive.rs`, since it uses an intrusive linked list. `no_std.rs` is now `slab.rs`, since it relies on a structure similar to the one used in the `slab` crate. Signed-off-by: John Nunley <[email protected]>
fogti
requested changes
Nov 18, 2024
notgull
force-pushed
the
notgull/cs
branch
2 times, most recently
from
a6bd06d to
a90f8ff
Compare
fogti
approved these changes
Nov 23, 2024
fogti
reviewed
Nov 27, 2024
fogti
reviewed
Nov 27, 2024
- Untangle imports. - Inline the entirely of ListLock into with_inner(). - Add documentation for feature. Signed-off-by: John Nunley <[email protected]>
fogti
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current no-std implementation is somewhat ineffecient, potentially
broken and relies on some slow data structures. The main reason why we
use this implementation is because we don't have a way to "lock" the
linked list, since there's no way to lock things in no-std. However,
many embedded platforms have a concept of a "critical section" that can
be used to exclusively lock something.
This PR adds an option to the "std" implementation that replaces the
existing Mutex with a usage of the critical-section crate. This is
enabled with the "critical-section" feature. This allows us to have the
advantages of the std-based implementation without needing to rely on
std for platforms that don't have it.