chore: update dependencies to latest versions and bump MSRV to 1.63 #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, wyhash has been released which moves to rand 0.9, which brings quite a few of breaking changes. Luckily, we don't depend on it too much so the move is trivial.
istankovic
changed the title
taiki-e
reviewed
May 23, 2025
| @@ -66,7 +66,7 @@ jobs: | |||
| # Use no-std target to ensure we don't link to std. | |||
| run: cargo build --no-default-features --features alloc --target thumbv7m-none-eabi | |||
| - name: Test wasm | |||
| run: wasm-pack test --headless --chrome | |||
| run: RUSTFLAGS='--cfg getrandom_backend="wasm_js"' wasm-pack test --headless --chrome | |||
There was a problem hiding this comment.
Unfortunately, the fact that this flag is needed indicates that the getrandom upgrade needs to be considered a breaking change for our crate as well...
There was a problem hiding this comment.
Yes, true, I'm afraid there's no way around that.
|
@taiki-e would it be possible to merge this and release a new major version (3.0, since this is a breaking change) soon-ish? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, wyhash has been released which moves to rand 0.9, which brings quite a few of breaking changes. Luckily, we don't depend on it too much so the move is trivial. Also bump the MSRV to 1.63 to be in sync with getrandom and rand.