Update to Ecto 3.0 and remove timex_ecto. This fixes #394 #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cast only accepts atoms in the future, so I made sure we were only using those. Applications should not be defined. This would lead to errors otherwise. migrations_path is now Ecto.Migrator.migrations_path
Author
|
I also upgraded to Ecto 3.0. to fully fix #394. I fixed the resulting warnings and errors. |
johannesE
changed the title
|
You can easily include this version of
|
Author
While that is true, I do not plan to become the new maintainer for coherence ;-). Maybe someone could review this? @smpallen99 |
You're on dude! Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be completely stupid. But I didn't find any usage of
Timex.Ecto.*anywhere in the code and the Tests are still green.