Skip to content

Conversation

@kenvandine
Copy link
Contributor

Adds args necessary to enable wayland in electron

lucyllewy
lucyllewy previously approved these changes Apr 26, 2023
Copy link
Member

@lucyllewy lucyllewy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Just need to wait on the build check before we merge.

@lucyllewy
Copy link
Member

This causes a regression: #74

@lucyllewy lucyllewy dismissed their stale review April 26, 2023 21:15

regression #74

@kenvandine kenvandine marked this pull request as draft April 27, 2023 08:34
jnsgruk and others added 18 commits June 20, 2023 08:04
chore: bump version to 5.4.0
 Add support for arm64 architecture in addition to amd64, as supported by upstream deb availability
chore: bump version to 5.5.0
* remove cruft
* remove part
* fix: add 'parts' heading back in

---------

Co-authored-by: Jon Seager <[email protected]>
* ci: use latest snapcrafters actions

* ci: add testing-issue-template

* ci: add dependabot to auto-bump github actions versions
Bumps [actions/github-script](https://github.com/actions/github-script) from 6 to 7.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v6...v7)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [xt0rted/slash-command-action](https://github.com/xt0rted/slash-command-action) from 1 to 2.
- [Release notes](https://github.com/xt0rted/slash-command-action/releases)
- [Changelog](https://github.com/xt0rted/slash-command-action/blob/main/CHANGELOG.md)
- [Commits](xt0rted/slash-command-action@v1...v2)

---
updated-dependencies:
- dependency-name: xt0rted/slash-command-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* docs: update snapcraft.yaml to include more detailed metadata

* docs: add additional metadata, and icon

* docs: include icon field in snapcraft.yaml
@jnsgruk
Copy link
Member

jnsgruk commented Dec 15, 2023

@kenvandine @lucyllewy it might be worth picking this one back up once the release workflow completes today - the latest version of Mattermost bumps the electron version :)

@kenvandine
Copy link
Contributor Author

I've rebased my branch and tested again with 5.6 and the resize bug still persist. Looking at the various upstream references, wayland with hidpi issues are resolved but not the resizing bug.

@jnsgruk
Copy link
Member

jnsgruk commented Feb 6, 2024

Closing this for now. Commits have got a bit messy through the rebase, and we're still working against upstream issues. Let's follow the upstream and revisit this another time.

@jnsgruk jnsgruk closed this Feb 6, 2024
@jnsgruk jnsgruk deleted the enable-wayland branch February 6, 2025 17:44
@kenvandine kenvandine mentioned this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants