fix: use blockHash to fetch single block events#371
Merged
Conversation
Our previous assumption of every block having an event didn't hold: https://sepolia.starkscan.co/block/924016 Instead we use blockHash based event filter which will throw if node doesn't know about given block (as opposed to just returning empty response).
Sekhmet
force-pushed
the
sekhmet/starknet-empty-blocks
branch
from
3959286 to
76a2456
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/snapshot-labs/workflow/issues/613
Depends on: #370
Our previous assumption of every block having an event didn't hold: https://sepolia.starkscan.co/block/924016
Instead we use blockHash based event filter which will throw if node doesn't know about given block (as opposed to just returning empty response).