Merged
Conversation
When indexing multiple sources we start from lowest block possible. For example, if we index ContractA from block 1000 and ContractB from block 2500, and preload step would be 1000 blocks we would preload as such: 1. (1000, 2000) with sources [ContractA] 2. (2000, 3000) with sources [CotnractA] - because we look at sources from 2000. With this fix we will actually use end-blocks sources so this won't happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When indexing multiple sources we start from lowest block possible. For example, if we index ContractA from block 1000 and ContractB from block 2500, and preload step would be 1000 blocks we would preload as such:
With this fix we will actually use end-blocks sources so this won't happen.