Skip to content

SNOW-865533: Exclude vulnerable vm2 transitive dependency #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2023
Merged

SNOW-865533: Exclude vulnerable vm2 transitive dependency #575

merged 3 commits into from
Jul 20, 2023

Conversation

sfc-gh-dprzybysz
Copy link
Contributor

Description

Exclude vulnerable vm2 transitive dependency

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dprzybysz sfc-gh-dprzybysz mentioned this pull request Jul 18, 2023
Closed
5 tasks
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-865533-override-vulnerable-vm2-dependency branch from 4b5786f to ef8dc91 Compare July 19, 2023 05:50
sfc-gh-igarish
sfc-gh-igarish approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discuss with Louie and looks good.

@sfc-gh-igarish sfc-gh-igarish marked this pull request as ready for review July 19, 2023 18:50
@sfc-gh-igarish sfc-gh-igarish requested a review from a team as a code owner July 19, 2023 18:50
@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #575 (862ba6a) into master (7950097) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #575   +/-   ##
=======================================
  Coverage   84.51%   84.51%           
=======================================
  Files          54       54           
  Lines        5135     5135           
=======================================
  Hits         4340     4340           
  Misses        795      795

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 4cacb2c into master Jul 20, 2023
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-865533-override-vulnerable-vm2-dependency branch July 20, 2023 06:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-dprzybysz @sfc-gh-igarish