Skip to content

Snow 2117128 Fix arrow timestamp conversion #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 22, 2025

Conversation

sfc-gh-pczajka
Copy link
Collaborator

@sfc-gh-pczajka sfc-gh-pczajka commented Jul 18, 2025

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-2117128

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Arrow conversion of timezoned timestamps on nanoseconds were overflowing int64. This change implements fix proposed for in ntz timestamps - converting dates outside nanoseconds range on microsecond precision and throwing an error if precision would be lost.

  4. (Optional) PR for stored-proc connector:
    TBD

@sfc-gh-pczajka sfc-gh-pczajka enabled auto-merge (squash) July 22, 2025 09:00
@sfc-gh-pczajka sfc-gh-pczajka merged commit 56e524e into main Jul 22, 2025
91 of 98 checks passed
@sfc-gh-pczajka sfc-gh-pczajka deleted the SNOW-2117128-fix-arrow-timestamp-conversion branch July 22, 2025 09:15
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants