-
Notifications
You must be signed in to change notification settings - Fork 187
SNOW-2117143 CRL caching #2294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
SNOW-2117143 CRL caching #2294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ad5290 to
5e564ce
Compare
sfc-gh-pfus
reviewed
Aug 7, 2025
src/test/java/net/snowflake/client/core/crl/CRLCacheManagerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/core/crl/CertificateGeneratorUtil.java
Show resolved
Hide resolved
f028917 to
5bb96d6
Compare
5e564ce to
6317637
Compare
10dbaa8 to
ae7b831
Compare
ae7b831 to
61b43f9
Compare
src/main/java/net/snowflake/client/core/crl/CRLCacheManager.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/crl/CRLCacheManager.java
Outdated
Show resolved
Hide resolved
sfc-gh-pfus
approved these changes
Aug 26, 2025
sfc-gh-dheyman
approved these changes
Aug 28, 2025
Collaborator
Author
|
Test failures are not related to this change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-XXXXX
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.