fix: [OSM-2746] Fixed bundle generation by splitting out the eslint-specific tsconfig #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjheppell
approved these changes
May 1, 2025
Comment on lines
-21
to
-23
| "exclude": [ | ||
| "node_modules" | ||
| ] |
There was a problem hiding this comment.
It's a good question, the only thing i know is that all other projects don't have it
|
🎉 This PR is included in version 1.12.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Include only
libwhen building the project under/dist.Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
In the previous PR I added "test" to
tsconfig.jsonbecause eslint was complaining about test files missing a project. But doing so made thetsccommand include bothlibandtestdirectories under/distwhen building the plugin; while before the config oflibwas inlined directly under/dist.The config has been mostly copied from https://github.com/snyk/snyk-gradle-plugin/blob/3ee9402f50ba90d9a767b112993d77e5412388a3/.eslintrc.json
What are the relevant tickets?
https://snyksec.atlassian.net/browse/OSM-2746
Screenshots
Additional questions