Fix fg/bg extraction with l.t. 2 colors #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Update: just realized about the |
Contributor
|
Looks good! All the tests still pass, and this will make us more resilient in the future. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR fixes a bug I found because I have a configuration like this:
In short, it wasn't considered the case where 1) less than 2 colors are specified, with 2) at least one modifier different from
boldorreverse.The bug can be reproduced by setting
git config color.diff.old "red strike"intest/test_helper/util.bashand running the test suite, but I'm not familiar enough with bats to add a regression test, as it seems to affect the configuration before the tests run.I hope it is useful :)