fix(complex-types): handle optional properties

[ilyaliao]

The interface of ButtonHTMLAttributes is

export interface ButtonHTMLAttributes extends HTMLAttributes {
    autofocus?: Booleanish;
    disabled?: Booleanish;
    form?: string;
    formaction?: string;
    formenctype?: string;
    formmethod?: string;
    formnovalidate?: Booleanish;
    formtarget?: string;
    name?: string;
    type?: 'submit' | 'reset' | 'button';
    value?: string | ReadonlyArray<string> | number;
}

This PR sets the required flag to false when a prop is optional.

Before:

After:

Summary by CodeRabbit

• Refactor
  • Improved handling of optional property markers for both mapped and non-mapped types, ensuring more accurate display of optional properties.

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[coderabbitai]

Walkthrough

The update refactors the logic in the printByType method within the printer.ts file. It introduces a boolean to identify mapped type nodes and adjusts how the questionToken string is determined for each property. For mapped types, the token is derived from the node's questionToken property; for other types, it checks if the property symbol is optional and assigns a "?" accordingly. The change clarifies and corrects the handling of optional property markers in the output.

Changes

File(s)	Change Summary
packages/complex-types/src/core/printer.ts	Refactored printByType method to improve and clarify logic for assigning questionToken based on node type and property optionality. No changes to exported or public entity declarations.

Poem

A rabbit hopped through printer code,
Where question marks and tokens flowed.
With mapped types clear and options bright,
Each property now prints just right.
Refactored paths, a tidy den,
The bunny’s work is done again! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0fc7203 and 61b7d9f.

⛔ Files ignored due to path filters (2)

• packages/complex-types/test/__snapshots__/fixtures-compiled.test.ts.snap is excluded by !**/*.snap
• packages/complex-types/test/__snapshots__/fixtures.test.ts.snap is excluded by !**/*.snap

📒 Files selected for processing (1)

• packages/complex-types/src/core/printer.ts (1 hunks)

🔇 Additional comments (1)

packages/complex-types/src/core/printer.ts (1)

63-68: Improved handling of optional properties!

This refactoring correctly differentiates between mapped types and regular property optionality. Using the isMapped boolean to cache the result of ts.isMappedTypeNode(node) is a good optimization, and the conditional logic properly handles both cases:

1. For mapped types: Uses the node's questionToken
2. For regular types: Checks the property symbol's Optional flag

This change properly fixes the issue with optional properties in interfaces like ButtonHTMLAttributes.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.