treewide: introduce hydra jobs #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djacu
force-pushed
the
djacu/create-proper-hydra-jobs
branch
2 times, most recently
from
235d7f1 to
f662212
Compare
Member
|
@djacu per usual youve made me feel like: 🤯 Im going to taking this for a spin in the morning, but can't wait to see my laptop get put through it's paces 🚀 |
Member
sarcasticadmin
left a comment
sarcasticadmin
left a comment
There was a problem hiding this comment.
@djacu very cool! I had a couple of comments/questions for you. Also did did some basic speed tests:
Current speed: 1:29s (roughly) for: nix run .#verify-scale-nixos-tests:
┏━ Dependency Graph with 4 roots:
┃ ┌─ ✔ nixos-system-coremaster-test
┃ ┌─ ✔ closure-info
┃ ┌─ ✔ run-nixos-vm
┃ ┌─ ✔ nixos-vm
┃ ┌─ ✔ nixos-test-driver-core ⏱ 12s
┃ ✔ vm-test-run-core ⏱ 38s
┃ ┌─ ✔ run-nixos-vm ⏱ 1s
┃ ┌─ ✔ nixos-vm
┃ ┌─ ✔ nixos-test-driver-wasgeht ⏱ 13s
┃ ✔ vm-test-run-wasgeht ⏱ 20s
┃ ┌─ ✔ run-nixos-vm
┃ ┌─ ✔ nixos-vm
┃ ┌─ ✔ nixos-test-driver-monitor ⏱ 13s
┃ ✔ vm-test-run-monitor ⏱ 41s
┃ ✔ vm-test-run-routers ⏱ 1m10s
┣━━━ Builds
┗━ ∑ ⏵ 0 │ ✔ 40 │ ⏸ 0 │ Finished at 22:44:54 after 1m29s
/nix/store/q9x25kr9qlzbyh9h01ajxzwfw20z2n9k-vm-test-run-core
/nix/store/zblxilvy249n1nj25lbfslx3l1nic86l-vm-test-run-loghost
/nix/store/13h1sicwp2p40f8422lp4ljngy4mlk9w-vm-test-run-monitor
/nix/store/9id8vb4ikw65bc50mm7355j9sbp36iqv-vm-test-run-borderrouter
/nix/store/yjbf00wznmcbmz04hlbyw15i41rl115p-vm-test-run-routers
/nix/store/95slynaq39fsvs0scamrdk8ajvdb60z0-vm-test-run-wasgeht
Previous time: 2m26s for nix flake check :
$ time nix flake check
warning: unknown flake output 'formatterModule'
warning: unknown flake output 'library'
warning: The check omitted these incompatible systems: aarch64-darwin, aarch64-linux, x86_64-darwin
Use '--all-systems' to check all.
real 2m26.011s
user 1m26.802s
sys 0m13.399s
Any concern with #1064 I think itll merge fine with your changes here but wanted to get your thoughts
| tags: | ||
| - nix | ||
| stage: test | ||
| timeout: 1 hour |
Member
There was a problem hiding this comment.
This could probably also be much lower. Id say we go with something like 30 minutes
| - run: nix build -L .#checks.x86_64-linux.formatting | ||
| nix_builds: | ||
| - run: nix flake check -L --allow-import-from-derivation | ||
| # monitor and bind-master uses IFD |
Member
There was a problem hiding this comment.
Im curious to hear plans for monitor and bind-master IFD usage 🙂
Member
|
Also subsequent runs 15s 🤤 |
Centralizes which systems we expose in the flake outputs.
djacu
force-pushed
the
djacu/create-proper-hydra-jobs
branch
3 times, most recently
from
6ecd79f to
121914b
Compare
These tests had path import to modules and it is not necessary.
Package ‘iproute2-6.15.0’ is only available on linux platforms.
Checks now only check formatting. verify-scale-network evaluates and builds everything in the scale-network scope.
Shorten timeout for nix flake check. Add `verify-scale-network` which builds all packages in the scale-network scope. Add `verify-scale-tests` which builds all packages in the scale-tests scope. Add `verify-scale-nixos-tests` which run all NixOS VM tests.
core vm test only runs on x86_64-linux because it has dhcptest as a dependency.
djacu
force-pushed
the
djacu/create-proper-hydra-jobs
branch
from
121914b to
c4d5970
Compare
djacu
force-pushed
the
djacu/create-proper-hydra-jobs
branch
from
c4d5970 to
d84e2b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Rework checks. Removes derivations and NixOS VM tests and creates hydra job for easier management of packages to build and NixOS VM tests to run.