Skip to content

Conversation

@sarcasticadmin
Copy link
Member

@sarcasticadmin sarcasticadmin commented Feb 1, 2026

Description of PR

relates to: #1006

Fixes the dhcp4-relay service to use the upstream and downstream interfaces

Adding the vlan, bridges, and address for conference 2.4ghz

Previous Behavior

  • no vlan, bridges, and address for conference 2.4ghz
  • wrong options for dhcp4-relay

New Behavior

  • vlan, bridges, and address for conference 2.4ghz
  • correct options for dhcp4-relay

Tests

  • confirmed working on conference router at work party

@sarcasticadmin sarcasticadmin changed the title nixos-modules.router.conf: adding wifi vlans [WAIT] nixos-modules.router.conf: adding wifi vlans Feb 1, 2026
@sarcasticadmin sarcasticadmin force-pushed the rh/1769986559route branch 4 times, most recently from a39624c to e62e8e9 Compare February 6, 2026 19:26
@sarcasticadmin sarcasticadmin changed the title [WAIT] nixos-modules.router.conf: adding wifi vlans [READY] nixos-modules.router.conf: adding wifi vlans Feb 6, 2026
@sarcasticadmin sarcasticadmin requested a review from djacu February 6, 2026 19:29
enable = mkEnableOption "SCaLE dhcp4-relay v4 monitoring service";

listenInterfaces = mkOption {
downstreamInterfaces = mkOption {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update the dhcp6-relay with a similar config when I get a change to test it in HE dc

Need to specify both interfaces for dhcp4-relay to work.
Starting with 2.4ghz network for the conference building.
relay the broadcast network for 2.4ghz vlan to core-conference
Copy link
Member

@kylerisse kylerisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @sarcasticadmin . I have no way to test but looks like it's all good from the work party verification.

@kylerisse kylerisse merged commit 3d02084 into master Feb 6, 2026
3 checks passed
@kylerisse kylerisse deleted the rh/1769986559route branch February 6, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants