Skip to content

Swift update #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Swift update #1126

merged 2 commits into from
Nov 28, 2018

Conversation

DmitryPR
Copy link

Bump Swift version in podspec to 4.2

Update Starscream to 3.0.6

Dmitry Preobrazhenskiy added 2 commits November 28, 2018 23:37
This solves the issue:
socketio#1101
This solves the issue:
socketio#1105
@nuclearace
Copy link
Member

Why is this needed? My previous experience with Xcode is that you can leave the Swift version at the last major version and it will pick up the newest compatible version.

@nuclearace
Copy link
Member

Also this would need to be opened on the development branch.

@DmitryPR DmitryPR changed the base branch from master to development November 28, 2018 21:54
@DmitryPR
Copy link
Author

DmitryPR commented Nov 28, 2018

As a framework developer I encountered an issue that the dependencies that I am using are not having the swift-version defined.

This leads to 2 problems:

  1. The podspec should really specify what swift version it has been adapted to, so the integrators know in advance what to expect when trying to solve different version problem

  2. pod package failed: "Swift Language Version" build setting CocoaPods/cocoapods-packager#210 and SWIFT_VERSION setting in s.pod_target_xcconfig is not being respected. CocoaPods/CocoaPods#7327

@nuclearace
Copy link
Member

Okay, just to play it as safe as possible, I'm going to go ahead and release 13.4.0 now before merging this. And this can be the starting point for v14.0.0. (Really the last release should have probably been 14 since Starscream actually broke semver in the last release).

@nuclearace nuclearace merged commit fa81fc2 into socketio:development Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants