Refactor requests between nodes and add clientRooms method#146
Refactor requests between nodes and add clientRooms method#146darrachequesne merged 1 commit intosocketio:masterfrom
clientRooms method#146Conversation
This PR refactors the way requests are sent between nodes. The `subJson` client has been removed, the subClient now listens to three channels by default: - the usual channel, where the message are broadcast - the request channel, where any node can request information (for now, the clients in a given rooms or the rooms for a given client) - the response channel, where a node will receive answer to its requests
|
Also, it should allow to add other useful requests, like making any socket.id join/leave a room, even on another node. |
|
This is nice, been waiting for this for a while now. socketio/socket.io#1884 |
|
Absolutely. Thank you @darrachequesne this PR would be really useful! |
|
Released as |
|
I can't seem to get These are my dependencies Both If I drop The code is below. |
|
Manually went through commits to find the first one that is causing |
|
That is the change induced by this very PR. Both Could you debug with |
|
See my PR #155 that fixed the issue for me. |
This PR refactors the way requests are sent between nodes. The
subJsonclient has been removed, the subClient now listens to three channels by
default:
the clients in a given rooms or the rooms for a given client)
Fixes #138 (no more
subJson)Closes #143 (add
clientRooms()method)@artofspeed would that suit your needs?