Connect request without transport fails server

[vostrik]

Query
/socket.io/?EIO=3
fails server

TypeError: Cannot read property 'prototype' of undefined
at Server.onWebSocket node_modules\engine.io\lib\server.js:343:12

[darrachequesne]

Hi, thanks for the report! Shouldn't it be caught in the verify method?

Which version are you using, and which options are you passing to the socket.io server?

[vostrik]

Our version is 1.5.0, we use default options.

In verify method you use Server.errors.UNKNOWN_TRANSPORT (which eq 0), then in handleUpgrade
if (err)
which 0 in this case, finally in onWebSocket method
if (!transports[req._query.transport].prototype.handlesUpgrades)
but req._query.transport can be wrong or empty.

[darrachequesne]

Hmm.. it should rather be if (!success), right? Like here.

[darrachequesne]

And... this was changed in socketio/engine.io#385.

[vostrik]

I use this url (via chrome plugin Smart WebSocket Client)

wss://127.0.0.1:3000/socket.io/?EIO=3

There is no handleRequest method in my error chain:

[vostrik]

As I understand it, you need to change Server.errors and Server.errorMessages enums 0 to another value.