Skip to content

Make it compile under Node 4.0.0; bump socket.io-client #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make it compile under Node 4.0.0; bump socket.io-client #2248

wants to merge 1 commit into from

Conversation

pmq20
Copy link
Contributor

@pmq20 pmq20 commented Sep 16, 2015

The previous reference automattic/socket.io-client#bf98153 points to 0.7.x of ws package which could not compile under Node 4.0.0.

We have to point to ws 0.8.0 to make it compile.

@pmq20 pmq20 mentioned this pull request Sep 16, 2015
Closed
@pmq20
Copy link
Contributor Author

pmq20 commented Sep 16, 2015

cf. https://github.com/websockets/ws

@pmq20 pmq20 mentioned this pull request Sep 16, 2015
Closed
@nkzawa
Copy link
Contributor

nkzawa commented Nov 23, 2015

Should be solved since it has reference of automattic/socket.io-client#master now.

@nkzawa nkzawa closed this Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmq20 @nkzawa