Skip to content

[CMake] Add flag to enable the use of a local directory for external projects #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bakpaul
Copy link
Contributor

@bakpaul bakpaul commented May 28, 2025

To use it you'll need to make sure that the flag SOFA_FETCH_XXX is set to OFF because it is prioritary + set the newly introduced flag XXX_LOCAL_DIRECTORY=absolute/path/to/repository. Along with SOFA_FETCH_XXX=OFF, the project will use the local clone instead of fetching it.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: new feature Implement a new feature labels May 28, 2025
@bakpaul bakpaul changed the title Add flag to enable the use of a local directory for external projects [CMake] Add flag to enable the use of a local directory for external projects May 28, 2025
@alxbilger
Copy link
Contributor

Tested with SofaGLFW and it works as intended 👍

@sofa-framework sofa-framework deleted a comment from sofabot May 28, 2025
@hugtalbot
Copy link
Contributor

This partially replaces the EXTERNAL_DIRECTORIES but still using the proper order of loading plugins as done in the applications/plugins/CMakeLists.txt, is this correct @bakpaul ?

@hugtalbot
Copy link
Contributor

@bakpaul
Copy link
Contributor Author

bakpaul commented Jun 4, 2025

See: sofa-framework/doc#192

@fredroy fredroy force-pushed the 25_05_add_mechanism_to_specify_local_folder_for_external_dir branch from f8309d3 to e9e592a Compare June 5, 2025 13:43
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 10, 2025
@fredroy fredroy merged commit 0fb23cb into sofa-framework:master Jun 10, 2025
15 checks passed
EulalieCoevoet pushed a commit to EulalieCoevoet/sofa that referenced this pull request Jun 17, 2025
…projects (sofa-framework#5511)

Add flag to enable the use of a local directory for external projects instead of fetching them
olivier-roussel pushed a commit to olivier-roussel/sofa that referenced this pull request Jun 20, 2025
…projects (sofa-framework#5511)

Add flag to enable the use of a local directory for external projects instead of fetching them
@hugtalbot hugtalbot added this to the v25.12 milestone Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: new feature Implement a new feature pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants