Skip to content

refactor: Remove name method calls from examples and tests #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 26, 2025

Conversation

aleksanderkatan
Copy link
Contributor

  • Removed $name calls from examples,
  • removed $name calls from some tests.

After trying to remove the $name calls from all tests, I opted to leave it in where it was at least somewhat relevant to the test, so for example when there was a parseResolved call or expected errors included the name.

@aleksanderkatan aleksanderkatan linked an issue Jun 26, 2025 that may be closed by this pull request
Copy link

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1407
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@456c42c8ab4ebb79e0b28da290fcdd1ec8db5138

benchmark
view benchmark

commit
view commit

@aleksanderkatan aleksanderkatan marked this pull request as ready for review June 26, 2025 10:08
Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, lots of cleanup! 🧹 🧽

@iwoplaza iwoplaza merged commit fd67137 into main Jun 26, 2025
6 checks passed
@iwoplaza iwoplaza deleted the docs/remove-name-method-calls-from-examples branch June 26, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Remove $name method calls from examples
2 participants