feat: Perlin Noise derivatives #1457
Merged
+575
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
reczkok
reviewed
Jul 7, 2025
| }); | ||
|
|
||
| const mainCompute = tgpu['~unstable'].computeFn({ | ||
| workgroupSize: [1, 1, 1], |
There was a problem hiding this comment.
We should consider making this more than one - if we look at our examples (game of life and fluid with atomics) there are significant performance gains when using higher workgroup sizes
There was a problem hiding this comment.
We should benchmark this but I think having workgroups at least a wavefront size (64 - which is 2 warps) with boundary checks inside the shader will be universally more performant
There was a problem hiding this comment.
Let's try to make this a separate PR. Could you try this out @reczkok?
There was a problem hiding this comment.
I will create a task for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Configurabletypeperlin2d.sampleWithGradientwith also returns the first derivative of the noise function (analytical solution)Changes to CI: