fix: use export type when exporting types#1874
Merged
Merged
Conversation
If you built your app using `esbuild` (for example using `@rnx-kit/metro-serializer-esbuild`), then it complains that the imports do not exist for type imports. Marking them explicitely as types fixes this issue, in addition to removing those import/exports from non-TS builds. I also transformed them from an import + export statements to an `export … from …` statement.
WoLewicki
approved these changes
Sep 27, 2022
Member
WoLewicki
left a comment
WoLewicki
left a comment
There was a problem hiding this comment.
LGTM 🎉 Thanks for your contribution!
Contributor
|
@WoLewicki, can we backport this to the 12.x branch? If yes, what is the process? I'd be happy to do it myself. |
4 tasks
WoLewicki
pushed a commit
that referenced
this pull request
Jan 31, 2023
If you built your app using `esbuild` (for example using [`@rnx-kit/metro-serializer-esbuild`](https://microsoft.github.io/rnx-kit/docs/tools/metro-serializer-esbuild)), then it complains that the imports do not exist for type imports. Marking them explicitely as types fixes this issue, in addition to removing those import/exports from non-TS builds. I also transformed them from an import + export statements to an `export … from …` statement.
WoLewicki
pushed a commit
that referenced
this pull request
Jan 3, 2024
…`tsc` (#2197) This is the same issue as the one I fixed last year in #1874 To prevent this from occurring again, I enabled the `isolatedModules` Typescript option which will warn when you export non-value identifiers without using `export type`, which will break transpilation processes what work on a per-file basis. You can find a [more detailed explanation in Typescript's doc](https://www.typescriptlang.org/tsconfig#isolatedModules)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If you built your app using
esbuild(for example using@rnx-kit/metro-serializer-esbuild), then it complains that the imports do not exist for type imports.Marking them explicitely as types fixes this issue, in addition to removing those import/exports from non-TS builds.
I also transformed them from an import + export statements to an
export … from …statement.Test Plan
This has been tested in my own app which uses the esbuild serializer mentioned above.
It only changes type exports, so no actual behaviour changes are expected
What's required for testing (prerequisites)?
Having an app using the esbuild serializer
What are the steps to reproduce (after prerequisites)?
Compatibility
Not relevant
Checklist
Not relevant