Don't set self.opaque = false on macOS#2008
Merged
Merged
Conversation
WoLewicki
approved these changes
Mar 22, 2023
Member
WoLewicki
left a comment
WoLewicki
left a comment
There was a problem hiding this comment.
LGTM 🚀 Thanks for your contribution!
Contributor
|
I was about to make this change... and saw it was made already, Thank you! Unexpected fallout from my RN-macOS change 😅 |
2 tasks
hyochan
referenced
this pull request
in hyochan/dooboo-ui
Apr 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://togithub.com/react-native-community/react-native-svg) | [`13.4.0` -> `13.9.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.4.0/13.9.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg</summary> ### [`v13.9.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.9.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.8.0...v13.9.0) Minor release introducing `marker` support for elements on `Android`, adding accessibility props needed also for e2e testing and fixing many issues in the repo 🎉 Thanks to all contributors! #### What's Changed - chore: update Example to newest react-native version by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1999](https://togithub.com/software-mansion/react-native-svg/pull/1999) - Upgrade rn-builder-bob to enable tree-shaking in rn-web by [@​merrywhether](https://togithub.com/merrywhether) in [https://github.com/software-mansion/react-native-svg/pull/1993](https://togithub.com/software-mansion/react-native-svg/pull/1993) - add accessibility and testId props and virtual nodes to support e2e tests tools by [@​toter3](https://togithub.com/toter3) in [https://github.com/software-mansion/react-native-svg/pull/2001](https://togithub.com/software-mansion/react-native-svg/pull/2001) - fix onLayout by [@​toter3](https://togithub.com/toter3) in [https://github.com/software-mansion/react-native-svg/pull/1998](https://togithub.com/software-mansion/react-native-svg/pull/1998) - Don't set `self.opaque = false` on macOS by [@​hsjoberg](https://togithub.com/hsjoberg) in [https://github.com/software-mansion/react-native-svg/pull/2008](https://togithub.com/software-mansion/react-native-svg/pull/2008) - Fix SVG parsing when the closing tags include whitespace by [@​MichalSzorad](https://togithub.com/MichalSzorad) in [https://github.com/software-mansion/react-native-svg/pull/2012](https://togithub.com/software-mansion/react-native-svg/pull/2012) - chore: set library namespace in build script by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-svg/pull/2005](https://togithub.com/software-mansion/react-native-svg/pull/2005) - fix: make image props extend CommonPathProps by [@​andev240](https://togithub.com/andev240) in [https://github.com/software-mansion/react-native-svg/pull/2007](https://togithub.com/software-mansion/react-native-svg/pull/2007) - fix: mask render on android by [@​Aflexon](https://togithub.com/Aflexon) in [https://github.com/software-mansion/react-native-svg/pull/1981](https://togithub.com/software-mansion/react-native-svg/pull/1981) - fix: remove unnecessary methods provided by superclasses for accessibility by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2013](https://togithub.com/software-mansion/react-native-svg/pull/2013) - chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/1982](https://togithub.com/software-mansion/react-native-svg/pull/1982) - chore(deps): bump [@​xmldom/xmldom](https://togithub.com/xmldom/xmldom) from 0.7.6 to 0.7.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/2004](https://togithub.com/software-mansion/react-native-svg/pull/2004) - fix [#​1592](https://togithub.com/react-native-community/react-native-svg/issues/1592) : add marker support on Rect, Line, Ellipse, Circle and Group by [@​mlecoq](https://togithub.com/mlecoq) in [https://github.com/software-mansion/react-native-svg/pull/1594](https://togithub.com/software-mansion/react-native-svg/pull/1594) - fix: scale path markers so they match ios by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2018](https://togithub.com/software-mansion/react-native-svg/pull/2018) - fix: read svg file on android by [@​vicke4](https://togithub.com/vicke4) in [https://github.com/software-mansion/react-native-svg/pull/2016](https://togithub.com/software-mansion/react-native-svg/pull/2016) #### New Contributors - [@​merrywhether](https://togithub.com/merrywhether) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1993](https://togithub.com/software-mansion/react-native-svg/pull/1993) - [@​toter3](https://togithub.com/toter3) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2001](https://togithub.com/software-mansion/react-native-svg/pull/2001) - [@​hsjoberg](https://togithub.com/hsjoberg) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2008](https://togithub.com/software-mansion/react-native-svg/pull/2008) - [@​MichalSzorad](https://togithub.com/MichalSzorad) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2012](https://togithub.com/software-mansion/react-native-svg/pull/2012) - [@​kkafar](https://togithub.com/kkafar) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2005](https://togithub.com/software-mansion/react-native-svg/pull/2005) - [@​andev240](https://togithub.com/andev240) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2007](https://togithub.com/software-mansion/react-native-svg/pull/2007) - [@​Aflexon](https://togithub.com/Aflexon) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1981](https://togithub.com/software-mansion/react-native-svg/pull/1981) - [@​mlecoq](https://togithub.com/mlecoq) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1594](https://togithub.com/software-mansion/react-native-svg/pull/1594) - [@​vicke4](https://togithub.com/vicke4) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2016](https://togithub.com/software-mansion/react-native-svg/pull/2016) **Full Changelog**: software-mansion/react-native-svg@v13.8.0...v13.9.0 ### [`v13.8.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.8.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.7.0...v13.8.0) Minor release bringing Fabric support to RN v0.71 🎉 #### What's Changed - feat: update FabricExample to 0.71.0-rc.6 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1962](https://togithub.com/software-mansion/react-native-svg/pull/1962) - chore: ensure consistent use of `import type` by [@​tido64](https://togithub.com/tido64) in [https://github.com/software-mansion/react-native-svg/pull/1971](https://togithub.com/software-mansion/react-native-svg/pull/1971) - chore: change fabric flag by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1979](https://togithub.com/software-mansion/react-native-svg/pull/1979) #### New Contributors - [@​tido64](https://togithub.com/tido64) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1971](https://togithub.com/software-mansion/react-native-svg/pull/1971) **Full Changelog**: software-mansion/react-native-svg@v13.7.0...v13.8.0 ### [`v13.7.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.7.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.6.0...v13.7.0) #### What's Changed - Fix windows build issues by [@​marlenecota](https://togithub.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1923](https://togithub.com/software-mansion/react-native-svg/pull/1923) - fix: fill/stroke setters and implement currentColor on Windows by [@​marlenecota](https://togithub.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1928](https://togithub.com/software-mansion/react-native-svg/pull/1928) - refactor: remove circular dependency by [@​Fasteel](https://togithub.com/Fasteel) in [https://github.com/software-mansion/react-native-svg/pull/1929](https://togithub.com/software-mansion/react-native-svg/pull/1929) - Include proguard config by [@​heroic](https://togithub.com/heroic) in [https://github.com/software-mansion/react-native-svg/pull/1842](https://togithub.com/software-mansion/react-native-svg/pull/1842) - fix: accept comas in viewbox by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1952](https://togithub.com/software-mansion/react-native-svg/pull/1952) - Fix nested SVGs in iOS [#​1437](https://togithub.com/react-native-community/react-native-svg/issues/1437) by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1948](https://togithub.com/software-mansion/react-native-svg/pull/1948) - fix: restore black as a default color for svgs by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1947](https://togithub.com/software-mansion/react-native-svg/pull/1947) - feat(windows): add clipPath and touch events by [@​marlenecota](https://togithub.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1933](https://togithub.com/software-mansion/react-native-svg/pull/1933) - fix: Call onLoad prop in SvgCssUri by [@​mantasio](https://togithub.com/mantasio) in [https://github.com/software-mansion/react-native-svg/pull/1927](https://togithub.com/software-mansion/react-native-svg/pull/1927) - feat(windows): add example app by [@​marlenecota](https://togithub.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1937](https://togithub.com/software-mansion/react-native-svg/pull/1937) #### New Contributors - [@​Fasteel](https://togithub.com/Fasteel) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1929](https://togithub.com/software-mansion/react-native-svg/pull/1929) - [@​heroic](https://togithub.com/heroic) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1842](https://togithub.com/software-mansion/react-native-svg/pull/1842) - [@​mantasio](https://togithub.com/mantasio) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1927](https://togithub.com/software-mansion/react-native-svg/pull/1927) **Full Changelog**: software-mansion/react-native-svg@v13.6.0...v13.7.0 ### [`v13.6.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.6.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.5.0...v13.6.0) Minor release fixing some bugs and introducing compatibility with Static View Configs, Bridgeless Mode and maybe some more updated on `Fabric`. #### What's Changed - chore: remove formatting from blame by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1905](https://togithub.com/software-mansion/react-native-svg/pull/1905) - feat: use codegenNativeComponent to import native views by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1847](https://togithub.com/software-mansion/react-native-svg/pull/1847) - chore: add react-native-svg banner to README by [@​kacperkapusciak](https://togithub.com/kacperkapusciak) in [https://github.com/software-mansion/react-native-svg/pull/1909](https://togithub.com/software-mansion/react-native-svg/pull/1909) - fix: make svg compile on older versions by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1907](https://togithub.com/software-mansion/react-native-svg/pull/1907) - chore: update RN versions to 0.70.5 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1910](https://togithub.com/software-mansion/react-native-svg/pull/1910) - fix: update supported RN version to 0.64 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1912](https://togithub.com/software-mansion/react-native-svg/pull/1912) - chore: align examples by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1914](https://togithub.com/software-mansion/react-native-svg/pull/1914) - chore: bump supported RN version for Fabric by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1913](https://togithub.com/software-mansion/react-native-svg/pull/1913) - feat: use transform parsing code from rn core by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1918](https://togithub.com/software-mansion/react-native-svg/pull/1918) #### New Contributors - [@​kacperkapusciak](https://togithub.com/kacperkapusciak) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1909](https://togithub.com/software-mansion/react-native-svg/pull/1909) **Full Changelog**: software-mansion/react-native-svg@v13.5.0...v13.6.0 ### [`v13.5.0`](https://togithub.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/dooboolab-community/dooboo-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuNTcuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
hyochan
referenced
this pull request
in hyochan/dooboo-ui
Jun 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://togithub.com/react-native-community/react-native-svg) | [`13.4.0` -> `13.9.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.4.0/13.9.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg</summary> ### [`v13.9.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.9.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.8.0...v13.9.0) Minor release introducing `marker` support for elements on `Android`, adding accessibility props needed also for e2e testing and fixing many issues in the repo 🎉 Thanks to all contributors! #### What's Changed - chore: update Example to newest react-native version by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1999](https://togithub.com/software-mansion/react-native-svg/pull/1999) - Upgrade rn-builder-bob to enable tree-shaking in rn-web by [@​merrywhether](https://togithub.com/merrywhether) in [https://github.com/software-mansion/react-native-svg/pull/1993](https://togithub.com/software-mansion/react-native-svg/pull/1993) - add accessibility and testId props and virtual nodes to support e2e tests tools by [@​toter3](https://togithub.com/toter3) in [https://github.com/software-mansion/react-native-svg/pull/2001](https://togithub.com/software-mansion/react-native-svg/pull/2001) - fix onLayout by [@​toter3](https://togithub.com/toter3) in [https://github.com/software-mansion/react-native-svg/pull/1998](https://togithub.com/software-mansion/react-native-svg/pull/1998) - Don't set `self.opaque = false` on macOS by [@​hsjoberg](https://togithub.com/hsjoberg) in [https://github.com/software-mansion/react-native-svg/pull/2008](https://togithub.com/software-mansion/react-native-svg/pull/2008) - Fix SVG parsing when the closing tags include whitespace by [@​MichalSzorad](https://togithub.com/MichalSzorad) in [https://github.com/software-mansion/react-native-svg/pull/2012](https://togithub.com/software-mansion/react-native-svg/pull/2012) - chore: set library namespace in build script by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-svg/pull/2005](https://togithub.com/software-mansion/react-native-svg/pull/2005) - fix: make image props extend CommonPathProps by [@​andev240](https://togithub.com/andev240) in [https://github.com/software-mansion/react-native-svg/pull/2007](https://togithub.com/software-mansion/react-native-svg/pull/2007) - fix: mask render on android by [@​Aflexon](https://togithub.com/Aflexon) in [https://github.com/software-mansion/react-native-svg/pull/1981](https://togithub.com/software-mansion/react-native-svg/pull/1981) - fix: remove unnecessary methods provided by superclasses for accessibility by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2013](https://togithub.com/software-mansion/react-native-svg/pull/2013) - chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/1982](https://togithub.com/software-mansion/react-native-svg/pull/1982) - chore(deps): bump [@​xmldom/xmldom](https://togithub.com/xmldom/xmldom) from 0.7.6 to 0.7.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/2004](https://togithub.com/software-mansion/react-native-svg/pull/2004) - fix [#​1592](https://togithub.com/react-native-community/react-native-svg/issues/1592) : add marker support on Rect, Line, Ellipse, Circle and Group by [@​mlecoq](https://togithub.com/mlecoq) in [https://github.com/software-mansion/react-native-svg/pull/1594](https://togithub.com/software-mansion/react-native-svg/pull/1594) - fix: scale path markers so they match ios by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2018](https://togithub.com/software-mansion/react-native-svg/pull/2018) - fix: read svg file on android by [@​vicke4](https://togithub.com/vicke4) in [https://github.com/software-mansion/react-native-svg/pull/2016](https://togithub.com/software-mansion/react-native-svg/pull/2016) #### New Contributors - [@​merrywhether](https://togithub.com/merrywhether) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1993](https://togithub.com/software-mansion/react-native-svg/pull/1993) - [@​toter3](https://togithub.com/toter3) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2001](https://togithub.com/software-mansion/react-native-svg/pull/2001) - [@​hsjoberg](https://togithub.com/hsjoberg) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2008](https://togithub.com/software-mansion/react-native-svg/pull/2008) - [@​MichalSzorad](https://togithub.com/MichalSzorad) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2012](https://togithub.com/software-mansion/react-native-svg/pull/2012) - [@​kkafar](https://togithub.com/kkafar) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2005](https://togithub.com/software-mansion/react-native-svg/pull/2005) - [@​andev240](https://togithub.com/andev240) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2007](https://togithub.com/software-mansion/react-native-svg/pull/2007) - [@​Aflexon](https://togithub.com/Aflexon) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1981](https://togithub.com/software-mansion/react-native-svg/pull/1981) - [@​mlecoq](https://togithub.com/mlecoq) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1594](https://togithub.com/software-mansion/react-native-svg/pull/1594) - [@​vicke4](https://togithub.com/vicke4) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2016](https://togithub.com/software-mansion/react-native-svg/pull/2016) **Full Changelog**: software-mansion/react-native-svg@v13.8.0...v13.9.0 ### [`v13.8.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.8.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.7.0...v13.8.0) Minor release bringing Fabric support to RN v0.71 🎉 #### What's Changed - feat: update FabricExample to 0.71.0-rc.6 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1962](https://togithub.com/software-mansion/react-native-svg/pull/1962) - chore: ensure consistent use of `import type` by [@​tido64](https://togithub.com/tido64) in [https://github.com/software-mansion/react-native-svg/pull/1971](https://togithub.com/software-mansion/react-native-svg/pull/1971) - chore: change fabric flag by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1979](https://togithub.com/software-mansion/react-native-svg/pull/1979) #### New Contributors - [@​tido64](https://togithub.com/tido64) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1971](https://togithub.com/software-mansion/react-native-svg/pull/1971) **Full Changelog**: software-mansion/react-native-svg@v13.7.0...v13.8.0 ### [`v13.7.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.7.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.6.0...v13.7.0) #### What's Changed - Fix windows build issues by [@​marlenecota](https://togithub.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1923](https://togithub.com/software-mansion/react-native-svg/pull/1923) - fix: fill/stroke setters and implement currentColor on Windows by [@​marlenecota](https://togithub.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1928](https://togithub.com/software-mansion/react-native-svg/pull/1928) - refactor: remove circular dependency by [@​Fasteel](https://togithub.com/Fasteel) in [https://github.com/software-mansion/react-native-svg/pull/1929](https://togithub.com/software-mansion/react-native-svg/pull/1929) - Include proguard config by [@​heroic](https://togithub.com/heroic) in [https://github.com/software-mansion/react-native-svg/pull/1842](https://togithub.com/software-mansion/react-native-svg/pull/1842) - fix: accept comas in viewbox by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1952](https://togithub.com/software-mansion/react-native-svg/pull/1952) - Fix nested SVGs in iOS [#​1437](https://togithub.com/react-native-community/react-native-svg/issues/1437) by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1948](https://togithub.com/software-mansion/react-native-svg/pull/1948) - fix: restore black as a default color for svgs by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1947](https://togithub.com/software-mansion/react-native-svg/pull/1947) - feat(windows): add clipPath and touch events by [@​marlenecota](https://togithub.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1933](https://togithub.com/software-mansion/react-native-svg/pull/1933) - fix: Call onLoad prop in SvgCssUri by [@​mantasio](https://togithub.com/mantasio) in [https://github.com/software-mansion/react-native-svg/pull/1927](https://togithub.com/software-mansion/react-native-svg/pull/1927) - feat(windows): add example app by [@​marlenecota](https://togithub.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1937](https://togithub.com/software-mansion/react-native-svg/pull/1937) #### New Contributors - [@​Fasteel](https://togithub.com/Fasteel) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1929](https://togithub.com/software-mansion/react-native-svg/pull/1929) - [@​heroic](https://togithub.com/heroic) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1842](https://togithub.com/software-mansion/react-native-svg/pull/1842) - [@​mantasio](https://togithub.com/mantasio) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1927](https://togithub.com/software-mansion/react-native-svg/pull/1927) **Full Changelog**: software-mansion/react-native-svg@v13.6.0...v13.7.0 ### [`v13.6.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.6.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.5.0...v13.6.0) Minor release fixing some bugs and introducing compatibility with Static View Configs, Bridgeless Mode and maybe some more updated on `Fabric`. #### What's Changed - chore: remove formatting from blame by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1905](https://togithub.com/software-mansion/react-native-svg/pull/1905) - feat: use codegenNativeComponent to import native views by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1847](https://togithub.com/software-mansion/react-native-svg/pull/1847) - chore: add react-native-svg banner to README by [@​kacperkapusciak](https://togithub.com/kacperkapusciak) in [https://github.com/software-mansion/react-native-svg/pull/1909](https://togithub.com/software-mansion/react-native-svg/pull/1909) - fix: make svg compile on older versions by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1907](https://togithub.com/software-mansion/react-native-svg/pull/1907) - chore: update RN versions to 0.70.5 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1910](https://togithub.com/software-mansion/react-native-svg/pull/1910) - fix: update supported RN version to 0.64 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1912](https://togithub.com/software-mansion/react-native-svg/pull/1912) - chore: align examples by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1914](https://togithub.com/software-mansion/react-native-svg/pull/1914) - chore: bump supported RN version for Fabric by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1913](https://togithub.com/software-mansion/react-native-svg/pull/1913) - feat: use transform parsing code from rn core by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1918](https://togithub.com/software-mansion/react-native-svg/pull/1918) #### New Contributors - [@​kacperkapusciak](https://togithub.com/kacperkapusciak) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1909](https://togithub.com/software-mansion/react-native-svg/pull/1909) **Full Changelog**: software-mansion/react-native-svg@v13.5.0...v13.6.0 ### [`v13.5.0`](https://togithub.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/dooboolab-community/dooboo-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTcuMyIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi, guys. In recent react-native-macos versions, react-native-svg is broken.
The reason for this is because microsoft/react-native-macos#1612 addressed some of the compiler warnings they were having, one of the being not redefining
opaqueforNSView.Now I see that you have a couple of
#ifdefsto deal with this already, but the check is not everywhere.This PR fixes this.
Test Plan
Test latest react-native-macos master with react-native-svg and it will complain that
opaqueisreadonly.With this PR, the issue is fixed.
What are the steps to reproduce (after prerequisites)?
Just using react-native-svg.