fix: Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file.#2191
Merged
Conversation
taenri
changed the title
taenri
changed the title
Member
|
@marlenecota wdyt about this one? |
marlenecota
approved these changes
Jan 12, 2024
Contributor
|
@WoLewicki - looks good! thanks |
Contributor
Author
|
@WoLewicki - Just curious, about when can we expect the next version update to be published? |
Member
|
I haven't planned the release soon, but you can always get those changes with a patch-package to be able to use them in current version 🚀 |
Contributor
Author
Wow, I have never heard of this before. Looks awesome, thanks for the tip! |
github-merge-queue Bot
referenced
this pull request
in valora-xyz/wallet
Apr 30, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://togithub.com/react-native-community/react-native-svg) | [`^13.14.0` -> `^15.2.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.14.0/15.2.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg (react-native-svg)</summary> ### [`v15.2.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.2.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v15.1.0...v15.2.0) Minor release adding support for RN 0.74 on New Architecture and introducing some bug fixes. Thank you for your contributions! #### What's Changed - feat: add needed changes for RN 0.74 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2231](https://togithub.com/software-mansion/react-native-svg/pull/2231) - Fix CMakeLists for Android by [@​tjzel](https://togithub.com/tjzel) in [https://github.com/software-mansion/react-native-svg/pull/2249](https://togithub.com/software-mansion/react-native-svg/pull/2249) - Adds support to compile react-native-svg against WinAppSDK by [@​rozele](https://togithub.com/rozele) in [https://github.com/software-mansion/react-native-svg/pull/2255](https://togithub.com/software-mansion/react-native-svg/pull/2255) - feat: bump RN to 0.74 in FabricExample and remove rea hacks by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2262](https://togithub.com/software-mansion/react-native-svg/pull/2262) - feat: bump RN to 0.74 in Example by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2263](https://togithub.com/software-mansion/react-native-svg/pull/2263) #### New Contributors - [@​tjzel](https://togithub.com/tjzel) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2249](https://togithub.com/software-mansion/react-native-svg/pull/2249) **Full Changelog**: software-mansion/react-native-svg@v15.1.0...v15.2.0 ### [`v15.1.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.1.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v15.0.0...v15.1.0) Minor release including proper support for `react-native-reanimated` to the library on new architecture by using `dynamic` values for codegen. ##### What's Changed - feat: use dynamics instead of strings for props that can be either string or number by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2238](https://togithub.com/software-mansion/react-native-svg/pull/2238) **Full Changelog**: software-mansion/react-native-svg@v15.0.0...v15.1.0 ### [`v15.0.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.0.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v14.1.0...v15.0.0) Major release introducing support for visionOS 🎉, some bug fixes and a BREAKING CHANGE due to [https://github.com/software-mansion/react-native-svg/pull/2232](https://togithub.com/software-mansion/react-native-svg/pull/2232). If your app already supports `iOS` >= `12.4` then you can safely upgrade the version, otherwise, you have to bump it first. #### What's Changed - feat: add visionOS support by [@​okwasniewski](https://togithub.com/okwasniewski) in [https://github.com/software-mansion/react-native-svg/pull/2190](https://togithub.com/software-mansion/react-native-svg/pull/2190) - fix: Correct types for transformsArrayToProps by [@​crazyfraggle](https://togithub.com/crazyfraggle) in [https://github.com/software-mansion/react-native-svg/pull/2193](https://togithub.com/software-mansion/react-native-svg/pull/2193) - chore: bump examples to 0.73.1 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2201](https://togithub.com/software-mansion/react-native-svg/pull/2201) - Fix type exports and enable `isolatedModules` setting to catch it in `tsc` by [@​renchap](https://togithub.com/renchap) in [https://github.com/software-mansion/react-native-svg/pull/2197](https://togithub.com/software-mansion/react-native-svg/pull/2197) - Fix crash when SVG is unloaded by XAML by [@​rozele](https://togithub.com/rozele) in [https://github.com/software-mansion/react-native-svg/pull/2195](https://togithub.com/software-mansion/react-native-svg/pull/2195) - fix(SvgCssUri): support rendering fallback instead of crashing the app when loading invalid content from remote svg file by [@​quangkcao](https://togithub.com/quangkcao) in [https://github.com/software-mansion/react-native-svg/pull/2196](https://togithub.com/software-mansion/react-native-svg/pull/2196) - fix: Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file. by [@​taenri](https://togithub.com/taenri) in [https://github.com/software-mansion/react-native-svg/pull/2191](https://togithub.com/software-mansion/react-native-svg/pull/2191) - Update ios-build-test.yml by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2207](https://togithub.com/software-mansion/react-native-svg/pull/2207) - fix: visionOS support by [@​tomekzaw](https://togithub.com/tomekzaw) in [https://github.com/software-mansion/react-native-svg/pull/2218](https://togithub.com/software-mansion/react-native-svg/pull/2218) - fixed [@​Deprecated](https://togithub.com/Deprecated) warning in React Native 0.73: 'com.facebook.react.common.StandardCharsets' is deprecated and marked for removal by [@​coder-xiaomo](https://togithub.com/coder-xiaomo) in [https://github.com/software-mansion/react-native-svg/pull/2208](https://togithub.com/software-mansion/react-native-svg/pull/2208) - fix: typo on require statement (`WithLocalSvg`) by [@​voidsatisfaction](https://togithub.com/voidsatisfaction) in [https://github.com/software-mansion/react-native-svg/pull/2223](https://togithub.com/software-mansion/react-native-svg/pull/2223) - fix: Add missing nan value checks for bounds size by [@​MatiPl01](https://togithub.com/MatiPl01) in [https://github.com/software-mansion/react-native-svg/pull/2220](https://togithub.com/software-mansion/react-native-svg/pull/2220) - chore(deps): bump ip from 1.1.8 to 1.1.9 in /Example by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/2228](https://togithub.com/software-mansion/react-native-svg/pull/2228) - feat: bump minimal ios version to 12.4 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2232](https://togithub.com/software-mansion/react-native-svg/pull/2232) #### New Contributors - [@​okwasniewski](https://togithub.com/okwasniewski) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2190](https://togithub.com/software-mansion/react-native-svg/pull/2190) - [@​crazyfraggle](https://togithub.com/crazyfraggle) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2193](https://togithub.com/software-mansion/react-native-svg/pull/2193) - [@​quangkcao](https://togithub.com/quangkcao) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2196](https://togithub.com/software-mansion/react-native-svg/pull/2196) - [@​taenri](https://togithub.com/taenri) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2191](https://togithub.com/software-mansion/react-native-svg/pull/2191) - [@​coder-xiaomo](https://togithub.com/coder-xiaomo) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2208](https://togithub.com/software-mansion/react-native-svg/pull/2208) - [@​voidsatisfaction](https://togithub.com/voidsatisfaction) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2223](https://togithub.com/software-mansion/react-native-svg/pull/2223) - [@​MatiPl01](https://togithub.com/MatiPl01) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2220](https://togithub.com/software-mansion/react-native-svg/pull/2220) **Full Changelog**: software-mansion/react-native-svg@v14.1.0...v15.0.0 ### [`v14.1.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v14.1.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v14.0.0...v14.1.0) Minor release adding support for RN 0.73 and fixing some bugs 🎉 Thank you for all your contributions! #### What's Changed - fix: remove unused header causing problems by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2175](https://togithub.com/software-mansion/react-native-svg/pull/2175) - fix `SvgCssUri` fallback by [@​myou11](https://togithub.com/myou11) in [https://github.com/software-mansion/react-native-svg/pull/2171](https://togithub.com/software-mansion/react-native-svg/pull/2171) - Minor fix to prevent crash when Loaded fires twice by [@​rozele](https://togithub.com/rozele) in [https://github.com/software-mansion/react-native-svg/pull/2180](https://togithub.com/software-mansion/react-native-svg/pull/2180) - feat: add support for RN 73 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2181](https://togithub.com/software-mansion/react-native-svg/pull/2181) #### New Contributors - [@​myou11](https://togithub.com/myou11) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2171](https://togithub.com/software-mansion/react-native-svg/pull/2171) - [@​rozele](https://togithub.com/rozele) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2180](https://togithub.com/software-mansion/react-native-svg/pull/2180) **Full Changelog**: software-mansion/react-native-svg@v14.0.0...v14.1.0 ### [`v14.0.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v14.0.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.14.0...v14.0.0) Major release introducing some minor improvements and a ***BREAKING CHANGE***. From now on, you should import SvgCss, SvgCssUri, SvgWithCss, SvgWithCssUri, inlineStyles, LocalSvg, WithLocalSvg, loadLocalRawResource, from `react-native-svg/css` package instead. See [#​2168](https://togithub.com/react-native-community/react-native-svg/issues/2168) for more information. #### What's Changed - enable buildConfig generation to better support AGP8 by [@​pvegh](https://togithub.com/pvegh) in [https://github.com/software-mansion/react-native-svg/pull/2143](https://togithub.com/software-mansion/react-native-svg/pull/2143) - perf: avoid unnecessary shared_ptr copies in Fabric components by [@​javache](https://togithub.com/javache) in [https://github.com/software-mansion/react-native-svg/pull/2164](https://togithub.com/software-mansion/react-native-svg/pull/2164) - fix: props are no longer unnecesarily copied in new architecture by [@​javache](https://togithub.com/javache) in [https://github.com/software-mansion/react-native-svg/pull/2163](https://togithub.com/software-mansion/react-native-svg/pull/2163) - chore(deps): bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.22.8 to 7.23.2 in /Example by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/2158](https://togithub.com/software-mansion/react-native-svg/pull/2158) - Build `renderer/components/rnsvg` with `-std=c++20` by [@​NickGerleman](https://togithub.com/NickGerleman) in [https://github.com/software-mansion/react-native-svg/pull/2141](https://togithub.com/software-mansion/react-native-svg/pull/2141) - chore: bump examples to rn 0.72.6 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2166](https://togithub.com/software-mansion/react-native-svg/pull/2166) - \[Windows] Port to Direct2D to remove win2d dependency by [@​marlenecota](https://togithub.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/2052](https://togithub.com/software-mansion/react-native-svg/pull/2052) - feat: move css to different package for size reduction by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2168](https://togithub.com/software-mansion/react-native-svg/pull/2168) #### New Contributors - [@​pvegh](https://togithub.com/pvegh) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2143](https://togithub.com/software-mansion/react-native-svg/pull/2143) - [@​javache](https://togithub.com/javache) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2164](https://togithub.com/software-mansion/react-native-svg/pull/2164) - [@​NickGerleman](https://togithub.com/NickGerleman) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2141](https://togithub.com/software-mansion/react-native-svg/pull/2141) **Full Changelog**: software-mansion/react-native-svg@v13.14.0...v14.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
](https://renovatebot.com){kind=link}
shottah
referenced
this pull request
in Kolektivo/Kolektivo-Mobile-App
May 15, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://togithub.com/react-native-community/react-native-svg) | [`^13.14.0` -> `^15.2.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.14.0/15.2.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg (react-native-svg)</summary> ### [`v15.2.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.2.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v15.1.0...v15.2.0) Minor release adding support for RN 0.74 on New Architecture and introducing some bug fixes. Thank you for your contributions! #### What's Changed - feat: add needed changes for RN 0.74 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2231](https://togithub.com/software-mansion/react-native-svg/pull/2231) - Fix CMakeLists for Android by [@​tjzel](https://togithub.com/tjzel) in [https://github.com/software-mansion/react-native-svg/pull/2249](https://togithub.com/software-mansion/react-native-svg/pull/2249) - Adds support to compile react-native-svg against WinAppSDK by [@​rozele](https://togithub.com/rozele) in [https://github.com/software-mansion/react-native-svg/pull/2255](https://togithub.com/software-mansion/react-native-svg/pull/2255) - feat: bump RN to 0.74 in FabricExample and remove rea hacks by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2262](https://togithub.com/software-mansion/react-native-svg/pull/2262) - feat: bump RN to 0.74 in Example by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2263](https://togithub.com/software-mansion/react-native-svg/pull/2263) #### New Contributors - [@​tjzel](https://togithub.com/tjzel) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2249](https://togithub.com/software-mansion/react-native-svg/pull/2249) **Full Changelog**: software-mansion/react-native-svg@v15.1.0...v15.2.0 ### [`v15.1.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.1.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v15.0.0...v15.1.0) Minor release including proper support for `react-native-reanimated` to the library on new architecture by using `dynamic` values for codegen. ##### What's Changed - feat: use dynamics instead of strings for props that can be either string or number by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2238](https://togithub.com/software-mansion/react-native-svg/pull/2238) **Full Changelog**: software-mansion/react-native-svg@v15.0.0...v15.1.0 ### [`v15.0.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.0.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v14.1.0...v15.0.0) Major release introducing support for visionOS 🎉, some bug fixes and a BREAKING CHANGE due to [https://github.com/software-mansion/react-native-svg/pull/2232](https://togithub.com/software-mansion/react-native-svg/pull/2232). If your app already supports `iOS` >= `12.4` then you can safely upgrade the version, otherwise, you have to bump it first. #### What's Changed - feat: add visionOS support by [@​okwasniewski](https://togithub.com/okwasniewski) in [https://github.com/software-mansion/react-native-svg/pull/2190](https://togithub.com/software-mansion/react-native-svg/pull/2190) - fix: Correct types for transformsArrayToProps by [@​crazyfraggle](https://togithub.com/crazyfraggle) in [https://github.com/software-mansion/react-native-svg/pull/2193](https://togithub.com/software-mansion/react-native-svg/pull/2193) - chore: bump examples to 0.73.1 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2201](https://togithub.com/software-mansion/react-native-svg/pull/2201) - Fix type exports and enable `isolatedModules` setting to catch it in `tsc` by [@​renchap](https://togithub.com/renchap) in [https://github.com/software-mansion/react-native-svg/pull/2197](https://togithub.com/software-mansion/react-native-svg/pull/2197) - Fix crash when SVG is unloaded by XAML by [@​rozele](https://togithub.com/rozele) in [https://github.com/software-mansion/react-native-svg/pull/2195](https://togithub.com/software-mansion/react-native-svg/pull/2195) - fix(SvgCssUri): support rendering fallback instead of crashing the app when loading invalid content from remote svg file by [@​quangkcao](https://togithub.com/quangkcao) in [https://github.com/software-mansion/react-native-svg/pull/2196](https://togithub.com/software-mansion/react-native-svg/pull/2196) - fix: Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file. by [@​taenri](https://togithub.com/taenri) in [https://github.com/software-mansion/react-native-svg/pull/2191](https://togithub.com/software-mansion/react-native-svg/pull/2191) - Update ios-build-test.yml by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2207](https://togithub.com/software-mansion/react-native-svg/pull/2207) - fix: visionOS support by [@​tomekzaw](https://togithub.com/tomekzaw) in [https://github.com/software-mansion/react-native-svg/pull/2218](https://togithub.com/software-mansion/react-native-svg/pull/2218) - fixed [@​Deprecated](https://togithub.com/Deprecated) warning in React Native 0.73: 'com.facebook.react.common.StandardCharsets' is deprecated and marked for removal by [@​coder-xiaomo](https://togithub.com/coder-xiaomo) in [https://github.com/software-mansion/react-native-svg/pull/2208](https://togithub.com/software-mansion/react-native-svg/pull/2208) - fix: typo on require statement (`WithLocalSvg`) by [@​voidsatisfaction](https://togithub.com/voidsatisfaction) in [https://github.com/software-mansion/react-native-svg/pull/2223](https://togithub.com/software-mansion/react-native-svg/pull/2223) - fix: Add missing nan value checks for bounds size by [@​MatiPl01](https://togithub.com/MatiPl01) in [https://github.com/software-mansion/react-native-svg/pull/2220](https://togithub.com/software-mansion/react-native-svg/pull/2220) - chore(deps): bump ip from 1.1.8 to 1.1.9 in /Example by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/2228](https://togithub.com/software-mansion/react-native-svg/pull/2228) - feat: bump minimal ios version to 12.4 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2232](https://togithub.com/software-mansion/react-native-svg/pull/2232) #### New Contributors - [@​okwasniewski](https://togithub.com/okwasniewski) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2190](https://togithub.com/software-mansion/react-native-svg/pull/2190) - [@​crazyfraggle](https://togithub.com/crazyfraggle) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2193](https://togithub.com/software-mansion/react-native-svg/pull/2193) - [@​quangkcao](https://togithub.com/quangkcao) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2196](https://togithub.com/software-mansion/react-native-svg/pull/2196) - [@​taenri](https://togithub.com/taenri) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2191](https://togithub.com/software-mansion/react-native-svg/pull/2191) - [@​coder-xiaomo](https://togithub.com/coder-xiaomo) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2208](https://togithub.com/software-mansion/react-native-svg/pull/2208) - [@​voidsatisfaction](https://togithub.com/voidsatisfaction) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2223](https://togithub.com/software-mansion/react-native-svg/pull/2223) - [@​MatiPl01](https://togithub.com/MatiPl01) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2220](https://togithub.com/software-mansion/react-native-svg/pull/2220) **Full Changelog**: software-mansion/react-native-svg@v14.1.0...v15.0.0 ### [`v14.1.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v14.1.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v14.0.0...v14.1.0) Minor release adding support for RN 0.73 and fixing some bugs 🎉 Thank you for all your contributions! #### What's Changed - fix: remove unused header causing problems by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2175](https://togithub.com/software-mansion/react-native-svg/pull/2175) - fix `SvgCssUri` fallback by [@​myou11](https://togithub.com/myou11) in [https://github.com/software-mansion/react-native-svg/pull/2171](https://togithub.com/software-mansion/react-native-svg/pull/2171) - Minor fix to prevent crash when Loaded fires twice by [@​rozele](https://togithub.com/rozele) in [https://github.com/software-mansion/react-native-svg/pull/2180](https://togithub.com/software-mansion/react-native-svg/pull/2180) - feat: add support for RN 73 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2181](https://togithub.com/software-mansion/react-native-svg/pull/2181) #### New Contributors - [@​myou11](https://togithub.com/myou11) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2171](https://togithub.com/software-mansion/react-native-svg/pull/2171) - [@​rozele](https://togithub.com/rozele) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2180](https://togithub.com/software-mansion/react-native-svg/pull/2180) **Full Changelog**: software-mansion/react-native-svg@v14.0.0...v14.1.0 ### [`v14.0.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v14.0.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.14.0...v14.0.0) Major release introducing some minor improvements and a ***BREAKING CHANGE***. From now on, you should import SvgCss, SvgCssUri, SvgWithCss, SvgWithCssUri, inlineStyles, LocalSvg, WithLocalSvg, loadLocalRawResource, from `react-native-svg/css` package instead. See [#​2168](https://togithub.com/react-native-community/react-native-svg/issues/2168) for more information. #### What's Changed - enable buildConfig generation to better support AGP8 by [@​pvegh](https://togithub.com/pvegh) in [https://github.com/software-mansion/react-native-svg/pull/2143](https://togithub.com/software-mansion/react-native-svg/pull/2143) - perf: avoid unnecessary shared_ptr copies in Fabric components by [@​javache](https://togithub.com/javache) in [https://github.com/software-mansion/react-native-svg/pull/2164](https://togithub.com/software-mansion/react-native-svg/pull/2164) - fix: props are no longer unnecesarily copied in new architecture by [@​javache](https://togithub.com/javache) in [https://github.com/software-mansion/react-native-svg/pull/2163](https://togithub.com/software-mansion/react-native-svg/pull/2163) - chore(deps): bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.22.8 to 7.23.2 in /Example by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/2158](https://togithub.com/software-mansion/react-native-svg/pull/2158) - Build `renderer/components/rnsvg` with `-std=c++20` by [@​NickGerleman](https://togithub.com/NickGerleman) in [https://github.com/software-mansion/react-native-svg/pull/2141](https://togithub.com/software-mansion/react-native-svg/pull/2141) - chore: bump examples to rn 0.72.6 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2166](https://togithub.com/software-mansion/react-native-svg/pull/2166) - \[Windows] Port to Direct2D to remove win2d dependency by [@​marlenecota](https://togithub.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/2052](https://togithub.com/software-mansion/react-native-svg/pull/2052) - feat: move css to different package for size reduction by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2168](https://togithub.com/software-mansion/react-native-svg/pull/2168) #### New Contributors - [@​pvegh](https://togithub.com/pvegh) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2143](https://togithub.com/software-mansion/react-native-svg/pull/2143) - [@​javache](https://togithub.com/javache) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2164](https://togithub.com/software-mansion/react-native-svg/pull/2164) - [@​NickGerleman](https://togithub.com/NickGerleman) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2141](https://togithub.com/software-mansion/react-native-svg/pull/2141) **Full Changelog**: software-mansion/react-native-svg@v13.14.0...v14.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows,
RNSVG.dllis getting flagged by AppLocker on many of our user's devices because it is missing proper publisher/versioning information in its metadata. This forces users to manually add this DLL to AppLocker's allow-list during some update/installation scenarios.The
RNSVG.slnfile also currently fails to build from Visual Studio directly, because thefmtproject is not explicitly included from thereact-native-windowsNode package.Test Plan
For testing, I opened
RNSVG.slnin Visual Studio on Windows (with Node packages installed and other build prerequisites) and built it forDebug|x64.Without my change, building the solution fails to build directly from Visual Studio (since it fails to link fmt.lib when building the Microsoft.ReactNative project). Even when building from the terminal using MSBuild,
RNSVG.dllproperties do not contain proper publisher/versioning details.With my change, building the solution in Visual Studio succeeds and
RNSVG.dllcontains the correct publisher/versioning details in its properties. These can be viewed via File Explorer.Note that the version constants defined in the
versionoverrides.rcfile will ideally need to be updated whenever the version tracked in package.json is updated. Further changes will be required to makeversionoverrides.rcaccount for thepackage.jsonversion automatically. This change is good enough to satisfy AppLocker requirements for now though.Compatibility
Checklist
README.md__tests__folder